Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387) #196839

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…M is enabled (elastic#196387)

## Summary

Closes elastic#196084.

We want to show Service, Host and Container views instead of onboarging
when EEM is enabled, entityCentricExperience advanced setting is enabled
and the entity has logs.

>[!NOTE]
The visibility of the noDataConfig is evaluated at a generic template
level for all 3 entity types.
To manage visibility based on entity-specific information (checking for
logs), we had to add checks within these templates. While this isn’t an
ideal solution, it’s temporary, as we expect upcoming generic entity
views will eventually allow us to remove this logic.

## Implementation details

There's no need to check if EEM is enabled, as the used `dataStreams`
information won’t return any results if EEM is disabled. This makes the
extra check unnecessary.

|Entity|Before|After|
|-|-|-|

|Service|![logs_only_service_before](https://github.com/user-attachments/assets/b92e7801-058d-4dc7-8cc8-eea128f19e4c)|![logs_only_service_after](https://github.com/user-attachments/assets/52eaa3cd-9cb9-427d-b9c2-d87ae6440dac)|

|Host/Container|![logs_only_host_before](https://github.com/user-attachments/assets/211b2f37-0cba-42e7-bb14-ad3f44fa1a51)|![logs_only_host_after](https://github.com/user-attachments/assets/32cab468-f3d0-49f9-8835-deb016189a14)|

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Cauê Marcondes <[email protected]>
(cherry picked from commit 586330b)
@kibanamachine kibanamachine enabled auto-merge (squash) October 18, 2024 10:26
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@iblancof iblancof requested a review from a team as a code owner October 21, 2024 07:49
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 21, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 3fef4ed
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196839-3fef4edf2efd

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1526 1527 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +141.0B
infra 1.7MB 1.7MB +466.0B
total +607.0B

History

cc @iblancof

@kibanamachine kibanamachine merged commit acaf103 into elastic:8.x Oct 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants