-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] fix incomplete string escaping or encoding #196248
Merged
mbondyra
merged 6 commits into
elastic:main
from
mbondyra:tsvb_fix_code_scanning_alerts_61-66
Oct 17, 2024
Merged
[TSVB] fix incomplete string escaping or encoding #196248
mbondyra
merged 6 commits into
elastic:main
from
mbondyra:tsvb_fix_code_scanning_alerts_61-66
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Feature:TSVB
TSVB (Time Series Visual Builder)
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Oct 15, 2024
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
nickofthyme
approved these changes
Oct 16, 2024
mbondyra
added
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
and removed
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Oct 17, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
## Summary Fixes incomplete string escaping or encoding for TSVB. (cherry picked from commit 7c4a83d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
## Summary Fixes incomplete string escaping or encoding for TSVB. (cherry picked from commit 7c4a83d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
## Summary Fixes incomplete string escaping or encoding for TSVB. (cherry picked from commit 7c4a83d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…196665) # Backport This will backport the following commits from `main` to `8.15`: - [[TSVB] fix incomplete string escaping or encoding (#196248)](#196248) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB] fix incomplete string escaping or encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…96668) # Backport This will backport the following commits from `main` to `8.x`: - [[TSVB] fix incomplete string escaping or encoding (#196248)](#196248) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB] fix incomplete string escaping or encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
This PR didn't make it into the latest BC of v8.15.3. Updating the labels. |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…196666) # Backport This will backport the following commits from `main` to `8.16`: - [[TSVB] fix incomplete string escaping or encoding (#196248)](#196248) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB] fix incomplete string escaping or encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB] fix incomplete string escaping or encoding (#196248)\n\n## Summary\r\n\r\nFixes incomplete string escaping or encoding for TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
Feature:TSVB
TSVB (Time Series Visual Builder)
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.15.4
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incomplete string escaping or encoding for TSVB.