Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][Otel] Add service view e2e tests using otel service #196542

Merged
merged 7 commits into from
Oct 17, 2024
Merged

[APM][Otel] Add service view e2e tests using otel service #196542

merged 7 commits into from
Oct 17, 2024

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Oct 16, 2024 •
edited by kibanamachine
Loading

Closes #193206

Summary

This PR adds service view e2e tests using otel service.

To run the tests:

  • Start server
    node x-pack/plugins/observability_solution/apm/scripts/test/e2e --server
  • Open Cypress
    node x-pack/plugins/observability_solution/apm/scripts/test/e2e --runner --open
  • Select otel_service_overview_and_transactions

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 backport:version Backport to applied version labels labels Oct 16, 2024
@jennypavlova jennypavlova self-assigned this Oct 16, 2024
@jennypavlova jennypavlova requested review from a team as code owners October 16, 2024 12:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 16, 2024
miloszmarcinkowski
miloszmarcinkowski approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@jennypavlova jennypavlova force-pushed the 193206-apmotel-add-e2e-tests-for-otel-services branch from aa11c89 to 7fb6ec4 Compare October 16, 2024 15:33
MiriamAparicio
MiriamAparicio approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding this tests, LGTM 🌟

rmyz
rmyz approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 1587bc0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196542-1587bc0f679d

History

cc @jennypavlova

@jennypavlova jennypavlova enabled auto-merge (squash) October 17, 2024 10:31
@jennypavlova jennypavlova merged commit 98ebd09 into elastic:main Oct 17, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11383808035

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [TSVB] fix incomplete string escaping or encoding (#196248)
- [ResponseOps][Rules][Alerts] Link stack rule details page refresh button to alerts table (#195736)
- [APM] Remove observability:searchExcludedDataTiers from serverless (#196380)
- [ObsUX] Unskip failing test (#196569)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196542

Questions ?

Please refer to the Backport tool documentation

@jennypavlova jennypavlova added backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels v8.16.0 labels Oct 17, 2024
@jennypavlova
Copy link
Member Author

I removed the backport labels as the synthtrace changes didn't make it to 8.16 so we will have the test in the next version as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@rmyz rmyz rmyz approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM][Otel] Add e2e tests for otel services
6 participants
@jennypavlova @elasticmachine @kibanamachine @rmyz @MiriamAparicio @miloszmarcinkowski