[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons #195693
+166
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
backport
release_note:skip
PhilippeOberti
force-pushed
the
cases-alerts-table-action-column
branch
from
0607465 to
a35e527
Compare
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
janmonschke
reviewed
Oct 10, 2024
x-pack/plugins/security_solution/public/common/components/header_actions/actions.test.tsx
Outdated
Show resolved
Hide resolved
janmonschke
reviewed
Oct 10, 2024
x-pack/plugins/security_solution/public/common/components/header_actions/actions.test.tsx
Outdated
Show resolved
Hide resolved
janmonschke
approved these changes
Oct 10, 2024
…width to show analyzer and session view icons
PhilippeOberti
force-pushed
the
cases-alerts-table-action-column
branch
from
1252a2d to
562c3ae
Compare
Merged
1 task
| ); | ||
| if (!visualizationInFlyoutEnabled && tableId === TableId.alertsOnCasePage) { | ||
| ACTION_BUTTON_COUNT -= 2; | ||
| } |
There was a problem hiding this comment.
@PhilippeOberti When license in not enterprise and advanced setting is off, the 3 dots still overlaps with the next column. Other scenarios LGTM!
There was a problem hiding this comment.
i see now, the session view count was done on line 33, so if it is not enterprise, line 50 should be -=1
There was a problem hiding this comment.
haaaaa good point. Let me fix that! Too many scenarios, I'm glad you're testing it in depth like that 😆
There was a problem hiding this comment.
I reworked a bit that code and added comments to make it more clear cb46c19
PhilippeOberti
force-pushed
the
cases-alerts-table-action-column
branch
from
b4f1d3d to
cb46c19
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
christineweng
approved these changes
Oct 11, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
…width to show analyzer and session view icons (elastic#195693) (cherry picked from commit ab248df)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…olumn width to show analyzer and session view icons (#195693) (#195981) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons (#195693)](#195693) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T19:05:43Z","message":"[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons (#195693)","sha":"ab248df4f8752c066f99acd2150578eab370211d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons","number":195693,"url":"https://github.com/elastic/kibana/pull/195693","mergeCommit":{"message":"[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons (#195693)","sha":"ab248df4f8752c066f99acd2150578eab370211d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195693","number":195693,"mergeCommit":{"message":"[Security Solution][Notes] - update cases alerts table action column width to show analyzer and session view icons (#195693)","sha":"ab248df4f8752c066f99acd2150578eab370211d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a small change to the width of the actions column for the alerts table displayed in the Alerts tab of Cases. An issue was introduced when this EUI PR was merged a few weeks back. It removed some css that was hiding some icons with a
overflow: hiddenOne fix could have to just hide the session view and analyzer graph icons on the Cases alerts table, but with this upcoming change (PR) we can now display those icons on the cases alerts table. We were previously hiding the icons because we did not have the ability to visualize session view and analyzer graph within the table, but we now that we have the ability to render these two in the flyout we can show the icons and have a consistent UI between all alerts tables.
Note that the visualization in flyout is controlled via an advanced settings (
securitySolution:enableVisualizationsInFlyout).Here are the scenario we want to support and that should be tested when reviewing this PR:
Also take into account when testing that the
securitySolutionNotesEnabledfeature flag can be toggled on or off, which has an impact on how many icons we show in the actions columns.Current behavior
New behavior when visualization in flyout advanced settings are enabled
New behavior when visualization in flyout advanced settings are disabled
