[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled #195687
+184
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
code LGTM and desk tested everything seems to be working perfectly!
As you said in Slack, it would be good to have other people test this before merging, as it might impact more things than you and I thought...
I did find a weird UI issue (not introduced by you, it is on main as well) on the cases page alerts tab actions column
I will investigate that bug!
💚 Build Succeeded
Metrics [docs]Async chunks
|
janmonschke
approved these changes
Oct 10, 2024
christineweng
added
backport:prev-minor
logeekal
reviewed
Oct 11, 2024
| ENABLE_VISUALIZATIONS_IN_FLYOUT_SETTING | ||
| ); | ||
|
|
||
| const { navigateToAnalyzer } = useNavigateToAnalyzer({ |
There was a problem hiding this comment.
I am thinking if It makes sense to delegate the responsibility of opening Analyzer either in tab or in flyout to useNavigateToAnalyzer.
With that logic becomes consolidated in one place and easy to refactor. But i am not too strongly opiniated about it. Just something to think about. I also understand if you would want to keep the current code as it is.
There was a problem hiding this comment.
@logeekal thank you for reviewing! i could see your point, the intention of the hooks was to reduce the duplication of openFlyout calls. i would think when it comes to removing the existing analyzer overlay, the code removal would be the same in either places. But I'll think more about it!
Given there is another PR depending on this one, I will merge it as is
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
… in flyout is enabled (elastic#195687) ## Summary When advanced setting `securitySolution:enableVisualizationsInFlyout` is enabled, clicking on analyzer or session view button should open the visualizations in flyout, the related tabs are also removed from timeline. https://github.com/user-attachments/assets/2502c1f5-f71b-4027-87a3-36cc73ea9451 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit bd22f13)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…zation in flyout is enabled (#195687) (#195945) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled (#195687)](#195687) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T15:00:42Z","message":"[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled (#195687)\n\n## Summary\r\n\r\nWhen advanced setting `securitySolution:enableVisualizationsInFlyout` is\r\nenabled, clicking on analyzer or session view button should open the\r\nvisualizations in flyout, the related tabs are also removed from\r\ntimeline.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2502c1f5-f71b-4027-87a3-36cc73ea9451\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd22f1370fc55179ea6f2737176570176f700b6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled","number":195687,"url":"https://github.com/elastic/kibana/pull/195687","mergeCommit":{"message":"[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled (#195687)\n\n## Summary\r\n\r\nWhen advanced setting `securitySolution:enableVisualizationsInFlyout` is\r\nenabled, clicking on analyzer or session view button should open the\r\nvisualizations in flyout, the related tabs are also removed from\r\ntimeline.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2502c1f5-f71b-4027-87a3-36cc73ea9451\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd22f1370fc55179ea6f2737176570176f700b6e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195687","number":195687,"mergeCommit":{"message":"[Security Solution] Update icons and timeline tabs when visualization in flyout is enabled (#195687)\n\n## Summary\r\n\r\nWhen advanced setting `securitySolution:enableVisualizationsInFlyout` is\r\nenabled, clicking on analyzer or session view button should open the\r\nvisualizations in flyout, the related tabs are also removed from\r\ntimeline.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2502c1f5-f71b-4027-87a3-36cc73ea9451\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd22f1370fc55179ea6f2737176570176f700b6e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When advanced setting
securitySolution:enableVisualizationsInFlyoutis enabled, clicking on analyzer or session view button should open the visualizations in flyout, the related tabs are also removed from timeline.Screen.Recording.2024-10-09.at.5.03.56.PM.mov
Checklist