Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Search][FTR] Solution Nav (#195327) #195610

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[8.x] [Search][FTR] Solution Nav (#195327) #195610

merged 1 commit into from
Oct 9, 2024

Conversation

TattdCodeMonkey
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@TattdCodeMonkey
[Search][FTR] Solution Nav (elastic#195327)
b5ebb4a 
## Summary

Adding `functional_search` suite with a set of test for the search
solution navigation. But this suite will also grow to test search
solution pages that do not require the enterprise search node.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 71fd96a)

# Conflicts:
#	.github/CODEOWNERS
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) October 9, 2024 14:10
@TattdCodeMonkey TattdCodeMonkey mentioned this pull request Oct 9, 2024
Merged
2 tasks
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TattdCodeMonkey TattdCodeMonkey merged commit 5991f4c into elastic:8.x Oct 9, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / Header rendering it renders the data providers when show is true

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +162.0B
Unknown metric groups

ESLint disabled in files

id before after diff
@kbn/test-suites-xpack 24 25 +1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 746 747 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TattdCodeMonkey @elasticmachine @Samiul-TheSoccerFan