[Search][FTR] Solution Nav #195327
Merged
[Search][FTR] Solution Nav #195327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
sebelga
reviewed
Oct 8, 2024
x-pack/test/functional_solution_sidenav/tests/search_sidenav.ts
Outdated
Show resolved
Hide resolved
TattdCodeMonkey
force-pushed
the
solution_sidenav/search-functional-tests
branch
from
b5d108b to
1e90725
Compare
Adding the function_search suite with a test for the new search solution nav. But this suite will also be a place where we can test search functionality not tied to the enterprise_search node.
TattdCodeMonkey
force-pushed
the
solution_sidenav/search-functional-tests
branch
from
1e90725 to
d956117
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7108[✅] x-pack/test/functional_search/config.ts: 25/25 tests passed. |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
jbudz
approved these changes
Oct 8, 2024
efegurkan
approved these changes
Oct 9, 2024
|
Starting backport for target branches: 8.x |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Adding `functional_search` suite with a set of test for the search solution navigation. But this suite will also grow to test search solution pages that do not require the enterprise search node. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit 71fd96a) # Conflicts: # .github/CODEOWNERS
TattdCodeMonkey
added a commit
that referenced
this pull request
Oct 9, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Search][FTR] Solution Nav (#195327)](#195327) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T13:45:24Z","message":"[Search][FTR] Solution Nav (#195327)\n\n## Summary\r\n\r\nAdding `functional_search` suite with a set of test for the search\r\nsolution navigation. But this suite will also grow to test search\r\nsolution pages that do not require the enterprise search node.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"71fd96ad8b8cd06ac3c30f099895f2723cd6f3bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"number":195327,"url":"https://github.com/elastic/kibana/pull/195327","mergeCommit":{"message":"[Search][FTR] Solution Nav (#195327)\n\n## Summary\r\n\r\nAdding `functional_search` suite with a set of test for the search\r\nsolution navigation. But this suite will also grow to test search\r\nsolution pages that do not require the enterprise search node.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"71fd96ad8b8cd06ac3c30f099895f2723cd6f3bc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195327","number":195327,"mergeCommit":{"message":"[Search][FTR] Solution Nav (#195327)\n\n## Summary\r\n\r\nAdding `functional_search` suite with a set of test for the search\r\nsolution navigation. But this suite will also grow to test search\r\nsolution pages that do not require the enterprise search node.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"71fd96ad8b8cd06ac3c30f099895f2723cd6f3bc"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding
functional_searchsuite with a set of test for the search solution navigation. But this suite will also grow to test search solution pages that do not require the enterprise search node.Checklist