Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Presentation Util] Remove the plugin services toolkit #195502

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[Presentation Util] Remove the plugin services toolkit #195502

merged 1 commit into from
Oct 8, 2024

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Oct 8, 2024 •
edited by kibanamachine
Loading

Closes #194199

Summary

Now that no plugins use anything from the PresentationUtil services toolkit, it is safe to remove all code and documentation related to this from the PresentationUtil plugin.

Checklist

  • Documentation was added for features that require explanation or tutorials

For maintainers

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 8, 2024
@Heenawter Heenawter self-assigned this Oct 8, 2024
@Heenawter Heenawter changed the title [Presentation Util] Remove the PluginServices registry [Presentation Util] Remove the plugin services toolkit Oct 8, 2024
@Heenawter Heenawter marked this pull request as ready for review October 8, 2024 22:28
@Heenawter Heenawter requested a review from a team as a code owner October 8, 2024 22:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationUtil 184 179 -5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 148 130 -18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
presentationUtil 87.2KB 87.3KB +76.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
presentationUtil 11 10 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
presentationUtil 35.5KB 31.4KB -4.1KB
Unknown metric groups

API count

id before after diff
presentationUtil 201 160 -41

cc @Heenawter

nreese
nreese approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@Heenawter Heenawter merged commit 1053493 into elastic:main Oct 8, 2024
35 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11244841311

@Heenawter Heenawter deleted the remove-services-util_2024-10-8 branch October 8, 2024 22:37
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
@Heenawter
[Presentation Util] Remove the plugin services toolkit (elastic#195502)
8cf8424 
Closes elastic#194199

## Summary

Now that no plugins use anything from the `PresentationUtil` services
toolkit, it is safe to remove all code and documentation related to this
from the `PresentationUtil` plugin.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 1053493)
@kibanamachine kibanamachine mentioned this pull request Oct 8, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
2 tasks
kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @Heenawter
[8.x] [Presentation Util] Remove the plugin services toolkit (#195502) (
8fdf77d 
#195517)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Presentation Util] Remove the plugin services toolkit
(#195502)](#195502)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T22:37:18Z","message":"[Presentation
Util] Remove the plugin services toolkit (#195502)\n\nCloses
https://github.com/elastic/kibana/issues/194199\r\n\r\n##
Summary\r\n\r\nNow that no plugins use anything from the
`PresentationUtil` services\r\ntoolkit, it is safe to remove all code
and documentation related to this\r\nfrom the `PresentationUtil`
plugin.\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1053493c9c66b881c27d14a600e33a16110b58e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","technical
debt","release_note:skip","impact:high","v9.0.0","backport:prev-minor"],"title":"[Presentation
Util] Remove the plugin services
toolkit","number":195502,"url":"https://github.com/elastic/kibana/pull/195502","mergeCommit":{"message":"[Presentation
Util] Remove the plugin services toolkit (#195502)\n\nCloses
https://github.com/elastic/kibana/issues/194199\r\n\r\n##
Summary\r\n\r\nNow that no plugins use anything from the
`PresentationUtil` services\r\ntoolkit, it is safe to remove all code
and documentation related to this\r\nfrom the `PresentationUtil`
plugin.\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1053493c9c66b881c27d14a600e33a16110b58e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195502","number":195502,"mergeCommit":{"message":"[Presentation
Util] Remove the plugin services toolkit (#195502)\n\nCloses
https://github.com/elastic/kibana/issues/194199\r\n\r\n##
Summary\r\n\r\nNow that no plugins use anything from the
`PresentationUtil` services\r\ntoolkit, it is safe to remove all code
and documentation related to this\r\nfrom the `PresentationUtil`
plugin.\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1053493c9c66b881c27d14a600e33a16110b58e3"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <[email protected]>
@ThomThomson
Copy link
Contributor

What a nice surprise to check my email for the first time in a month and see this completed! It makes me excited to come back to work in November!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees

@Heenawter Heenawter

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Presentation Util] Remove the PluginServices registry from PresentationUtil
5 participants
@Heenawter @elasticmachine @kibanamachine @ThomThomson @nreese