Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Delete unused sense models and unused files #195344

Merged
merged 8 commits into from
Oct 9, 2024
Merged

[Console] Delete unused sense models and unused files #195344

merged 8 commits into from
Oct 9, 2024

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Oct 8, 2024 •
edited by kibanamachine
Loading

Summary

As part of the effort being made with #194533, this PR removes all instances and usage of Ace/sense editor in favour of monaco. Also deletes a bunch of files that were not being used.

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 8, 2024
@sabarasaba sabarasaba self-assigned this Oct 8, 2024
@sabarasaba sabarasaba mentioned this pull request Oct 8, 2024
Closed
@elastic elastic deleted a comment from elasticmachine Oct 8, 2024
@sabarasaba sabarasaba marked this pull request as ready for review October 8, 2024 14:35
@sabarasaba sabarasaba requested review from a team as code owners October 8, 2024 14:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

ElenaStoeva
ElenaStoeva approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, it's awesome to see so much redundant code being removed! Tested locally for regressions, changes lgtm with one small comment.

src/plugins/console/public/styles/_app.scss Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
console 250 238 -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 208.1KB 205.5KB -2.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
console 40.1KB 38.2KB -1.9KB
Unknown metric groups

ESLint disabled in files

id before after diff
console 2 1 -1

ESLint disabled line counts

id before after diff
console 43 14 -29

Total ESLint disabled count

id before after diff
console 45 15 -30

History

cc @sabarasaba

andreadelrio
andreadelrio approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scss clean up looks good.

@sabarasaba sabarasaba merged commit d273c07 into elastic:main Oct 9, 2024
27 checks passed
@sabarasaba sabarasaba added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 and removed backport:skip This commit does not require backporting labels Oct 10, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271208739

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271208748

sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Oct 10, 2024
@sabarasaba
[Console] Delete unused sense models and unused files (elastic#195344)
af22345 
(cherry picked from commit d273c07)
@sabarasaba sabarasaba mentioned this pull request Oct 10, 2024
Closed
@sabarasaba
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 10, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
@sabarasaba
[Console] Delete unused sense models and unused files (elastic#195344)
796c650 
(cherry picked from commit d273c07)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
@kibanamachine @sabarasaba
[8.x] [Console] Delete unused sense models and unused files (#195344) (…
4d50545 
…#195728)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Delete unused sense models and unused files
(#195344)](#195344)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T15:54:43Z","message":"[Console]
Delete unused sense models and unused files
(#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console]
Delete unused sense models and unused
files","number":195344,"url":"https://github.com/elastic/kibana/pull/195344","mergeCommit":{"message":"[Console]
Delete unused sense models and unused files
(#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195344","number":195344,"mergeCommit":{"message":"[Console]
Delete unused sense models and unused files
(#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

Assignees

@sabarasaba sabarasaba

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabarasaba @elasticmachine @kibanamachine @andreadelrio @ElenaStoeva