Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ace editor in favour of Monaco #194533

Closed
sabarasaba opened this issue Oct 1, 2024 · 1 comment · Fixed by #195703
Closed

Remove Ace editor in favour of Monaco #194533

sabarasaba opened this issue Oct 1, 2024 · 1 comment · Fixed by #195703
Assignees
Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Milestone

Comments

@sabarasaba
Copy link
Member

sabarasaba commented Oct 1, 2024

There are still a few more places in which ace editor is being used, after we migrate these instances we can finally remove the ace dependency from the kibana project.

  • Delete console models as they are not used anymore [Console] Delete unused sense models and unused files #195344

    • src/plugins/console/public/application/models
  • Migrate plugins that directly use ace editor to kbn-editor [Search profiler] Migrate ace to monaco #195343

    • x-pack/plugins/searchprofiler/public/application/components/profile_query_editor/editor/init_editor.ts
    • x-pack/plugins/searchprofiler/public/application/components/profile_query_editor/editor/editor.tsx
  • Migrate plugins that use kbn-ace to kbn-editor Remove unusedkbn-ace code #195353

    • x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings.tsx
    • x-pack/plugins/data_visualizer/public/application/shared_imports.ts
    • x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/hooks/use_advanced_runtime_mappings_editor.ts
    • x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/hooks/use_advanced_pivot_editor.ts

After these have been migrated we can also remove the kbn-ace package.

@sabarasaba sabarasaba added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Oct 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants