[Lens] Fix partition theme after ech upgrade #195269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
Team:Visualizations
markov00
force-pushed
the
2024_10_07-fix_partition_theme_mini
branch
from
7feaa79 to
13dfdce
Compare
markov00
force-pushed
the
2024_10_07-fix_partition_theme_mini
branch
from
9efaaaf to
830f48c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
nickofthyme
approved these changes
Oct 7, 2024
src/plugins/chart_expressions/expression_partition_vis/public/utils/get_partition_theme.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
## Summary When I've updated elastic-charts with the last new version, the `point.fill` parameter of lineSeriesStyle has changed in value. This created an unwanted change also in the partition chart that was using that style to color the partition sector borders. I've removed the useless color override of `sectorLineStroke` in the overwrite partition theme, leaving the control to use the chart theme. I've also removed the possibility of unwanted changes for other properties like `fontFamily` and in the `linkedText.textColor`. In the same PR I've removed duplicated tests that where testing exactly the same code/arguments/data, the only difference was the test name. I've also refactored a bit the code, cleaning up the typings and consolidating a bit the theme override logic (cherry picked from commit 653073f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Lens] Fix partition theme after ech upgrade (#195269)](#195269) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T16:57:23Z","message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Lens] Fix partition theme after ech upgrade","number":195269,"url":"https://github.com/elastic/kibana/pull/195269","mergeCommit":{"message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195269","number":195269,"mergeCommit":{"message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #195197
When I've updated elastic-charts with the last new version, the
point.fillparameter of lineSeriesStyle has changed in value. This created an unwanted change also in the partition chart that was using that style to color the partition sector borders.I've removed the useless color override of
sectorLineStrokein the overwrite partition theme, leaving the control to use the chart theme.I've also removed the possibility of unwanted changes for other properties like
fontFamilyand in thelinkedText.textColor.In the same PR I've removed duplicated tests that where testing exactly the same code/arguments/data, the only difference was the test name.
I've also refactored a bit the code, cleaning up the typings and consolidating a bit the theme override logic