Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
# Backport This will backport the following commits from `main` to `8.x`: - [[Lens] Fix partition theme after ech upgrade (#195269)](#195269) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T16:57:23Z","message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Lens] Fix partition theme after ech upgrade","number":195269,"url":"https://github.com/elastic/kibana/pull/195269","mergeCommit":{"message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195269","number":195269,"mergeCommit":{"message":"[Lens] Fix partition theme after ech upgrade (#195269)\n\n## Summary\r\n\r\nWhen I've updated elastic-charts with the last new version, the\r\n`point.fill` parameter of lineSeriesStyle has changed in value. This\r\ncreated an unwanted change also in the partition chart that was using\r\nthat style to color the partition sector borders.\r\n\r\nI've removed the useless color override of `sectorLineStroke` in the\r\noverwrite partition theme, leaving the control to use the chart theme.\r\n\r\nI've also removed the possibility of unwanted changes for other\r\nproperties like `fontFamily` and in the `linkedText.textColor`.\r\n\r\nIn the same PR I've removed duplicated tests that where testing exactly\r\nthe same code/arguments/data, the only difference was the test name.\r\n\r\nI've also refactored a bit the code, cleaning up the typings and\r\nconsolidating a bit the theme override logic","sha":"653073f8c6d199b069830c3acc13fb0c6664e9d8"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
- Loading branch information