[Search][Homepage] Remove usage #194870
Merged
[Search][Homepage] Remove usage #194870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
TattdCodeMonkey
force-pushed
the
search-homepage/remove-ff-usage
branch
2 times, most recently
from
b0f2c1a to
a5744be
Compare
Search home page was feature flagged in serverless search. This project is currently on hold indefinitely, removing usage of the feature flag until the project starts up again.
The search home page project is on hold, removing usage of it from enterprise_search plugin.
TattdCodeMonkey
force-pushed
the
search-homepage/remove-ff-usage
branch
from
a5744be to
d0ceba3
Compare
The search home page project is on hold indefinitely, for now disabling the plugin by default unitl we start the project up again.
TattdCodeMonkey
force-pushed
the
search-homepage/remove-ff-usage
branch
from
d0ceba3 to
1250f13
Compare
joemcelroy
approved these changes
Oct 4, 2024
|
@elasticmachine merge upstream |
SiddharthMantri
approved these changes
Oct 4, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 4, 2024
## Summary Removing search home usage from serverless search and enterprise search. The search home page project is on hold while we re-assess requirements. Until we know when we are starting that back up I'm removing the feature flagged usage to simplify other work. When we spin this back up usage will likely be different anyway with other projects like onboarding and the updating navigation refactor in enterprise_search. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a84b3f8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Search][Homepage] Remove usage (#194870)](#194870) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T18:30:37Z","message":"[Search][Homepage] Remove usage (#194870)\n\n## Summary\r\n\r\nRemoving search home usage from serverless search and enterprise search.\r\nThe search home page project is on hold while we re-assess requirements.\r\nUntil we know when we are starting that back up I'm removing the feature\r\nflagged usage to simplify other work. When we spin this back up usage\r\nwill likely be different anyway with other projects like onboarding and\r\nthe updating navigation refactor in enterprise_search.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a84b3f841cd952bc3fc511000bf4fbfae4d5b083","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search][Homepage] Remove usage ","number":194870,"url":"https://github.com/elastic/kibana/pull/194870","mergeCommit":{"message":"[Search][Homepage] Remove usage (#194870)\n\n## Summary\r\n\r\nRemoving search home usage from serverless search and enterprise search.\r\nThe search home page project is on hold while we re-assess requirements.\r\nUntil we know when we are starting that back up I'm removing the feature\r\nflagged usage to simplify other work. When we spin this back up usage\r\nwill likely be different anyway with other projects like onboarding and\r\nthe updating navigation refactor in enterprise_search.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a84b3f841cd952bc3fc511000bf4fbfae4d5b083"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194870","number":194870,"mergeCommit":{"message":"[Search][Homepage] Remove usage (#194870)\n\n## Summary\r\n\r\nRemoving search home usage from serverless search and enterprise search.\r\nThe search home page project is on hold while we re-assess requirements.\r\nUntil we know when we are starting that back up I'm removing the feature\r\nflagged usage to simplify other work. When we spin this back up usage\r\nwill likely be different anyway with other projects like onboarding and\r\nthe updating navigation refactor in enterprise_search.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a84b3f841cd952bc3fc511000bf4fbfae4d5b083"}}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
## Summary Removing search home usage from serverless search and enterprise search. The search home page project is on hold while we re-assess requirements. Until we know when we are starting that back up I'm removing the feature flagged usage to simplify other work. When we spin this back up usage will likely be different anyway with other projects like onboarding and the updating navigation refactor in enterprise_search. --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing search home usage from serverless search and enterprise search. The search home page project is on hold while we re-assess requirements. Until we know when we are starting that back up I'm removing the feature flagged usage to simplify other work. When we spin this back up usage will likely be different anyway with other projects like onboarding and the updating navigation refactor in enterprise_search.