[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 #193638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate Vuln Schema imports
…rts to be from shared package
…/kibana into vulnerabilities-preview-phase1
…eview-phase2-branchedfromphase1
animehart
changed the title
…ist and field is hostname
…ithub.com:animehart/kibana into vulnerabilities-preview-phase2-branchedfromphase1
animehart
added
backport:prev-minor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
…ithub.com:animehart/kibana into vulnerabilities-preview-phase2-branchedfromphase1
|
Starting backport for target branches: 8.x |
💔 All backports failedManual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
animehart
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
animehart
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
animehart
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
animehart
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
animehart
added a commit
to animehart/kibana
that referenced
this pull request
Oct 7, 2024
elastic#193638) In an attempt to make Reviewing easier and more accurate, the implementation of Vulnerabilities on Host.name flyout in Alerts Page will be split into 2 Phases Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package Phase 2: Implementing the feature This is Phase 2 <img width="1465" alt="Screenshot 2024-09-20 at 5 33 01 PM" src="https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328"> --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Maxim Kholod <[email protected]> (cherry picked from commit 0b92c26) # Conflicts: # .github/CODEOWNERS
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
elastic#193638) In an attempt to make Reviewing easier and more accurate, the implementation of Vulnerabilities on Host.name flyout in Alerts Page will be split into 2 Phases Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package Phase 2: Implementing the feature This is Phase 2 <img width="1465" alt="Screenshot 2024-09-20 at 5 33 01 PM" src="https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328"> --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Maxim Kholod <[email protected]>
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
animehart
added a commit
that referenced
this pull request
Oct 8, 2024
…PHASE 2 (#193638) (#195230) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 (#193638)](#193638) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T19:28:18Z","message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 (#193638)\n\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature\r\n\r\nThis is Phase 2\r\n<img width=\"1465\" alt=\"Screenshot 2024-09-20 at 5 33 01 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0b92c268f9e862812a4c2ab4ba50a3b90bc87a65","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:build-cloud-image","ci:project-deploy-security","v8.16.0"],"number":193638,"url":"https://github.com/elastic/kibana/pull/193638","mergeCommit":{"message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 (#193638)\n\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature\r\n\r\nThis is Phase 2\r\n<img width=\"1465\" alt=\"Screenshot 2024-09-20 at 5 33 01 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0b92c268f9e862812a4c2ab4ba50a3b90bc87a65"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193638","number":193638,"mergeCommit":{"message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 (#193638)\n\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature\r\n\r\nThis is Phase 2\r\n<img width=\"1465\" alt=\"Screenshot 2024-09-20 at 5 33 01 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"0b92c268f9e862812a4c2ab4ba50a3b90bc87a65"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make Reviewing easier and more accurate, the implementation of Vulnerabilities on Host.name flyout in Alerts Page will be split into 2 Phases
Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package
Phase 2: Implementing the feature
This is Phase 2
