Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dataset Quality] Optimize bundle size and chunks fragmentation (#194661) #194746

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…tic#194661)

## 📓 Summary

Closes elastic#191602

This work reduces the initial bundle size for the dataset quality plugin
by **~55%** and reduces fragmentation in the chunks when the main page
loads.

| Before | After |
|--------|--------|
| <img width="525" alt="Screenshot 2024-10-02 at 09 56 35"
src="https://github.com/user-attachments/assets/06fec02c-ff2c-4771-981f-a761bda67eae">
| <img width="521" alt="Screenshot 2024-10-02 at 09 59 16"
src="https://github.com/user-attachments/assets/a243b09a-9d83-4d0d-b875-20855bb18f5d">
|
| <img width="1398" alt="Screenshot 2024-10-02 at 09 56 55"
src="https://github.com/user-attachments/assets/66d2c131-b0b7-47e1-9a9a-e1be57e69bbb">
| <img width="678" alt="Screenshot 2024-10-02 at 09 58 59"
src="https://github.com/user-attachments/assets/39e6515e-5a83-4d97-97c8-cce01b7c6887">
|

Co-authored-by: Marco Antonio Ghiani <[email protected]>
(cherry picked from commit ce8c9d8)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
datasetQuality 15 14 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 208.1KB 220.4KB +12.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 49.7KB 18.4KB -31.2KB
Unknown metric groups

API count

id before after diff
datasetQuality 15 14 -1

async chunk count

id before after diff
datasetQuality 16 13 -3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tonyghiani

@kibanamachine kibanamachine merged commit 0137e86 into elastic:8.x Oct 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants