[Dataset Quality] Optimize bundle size and chunks fragmentation #194661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
release_note:skip
tonyghiani
commented
Oct 2, 2024
Comment on lines
-59
to
-64
| const Header = dynamic(() => import('./header')); | ||
| const Warnings = dynamic(() => import('./warnings/warnings')); | ||
| const EmptyStateWrapper = dynamic(() => import('./empty_state/empty_state')); | ||
| const Table = dynamic(() => import('./table/table')); | ||
| const Filters = dynamic(() => import('./filters/filters')); | ||
| const SummaryPanel = dynamic(() => import('./summary_panel/summary_panel')); |
There was a problem hiding this comment.
Note
All of these chunks were loaded in parallel when loading the page, causing an excessive fragmentation for a UI that can loaded at once.
The lazy loading now happens for the main chunk on the index file, where the getter dynamically import the whole UI island.
There was a problem hiding this comment.
to better understand what happened here:
Should we use this approach then only for elements in the UI that are showed after some interaction? for example a flyout?
There was a problem hiding this comment.
Sort of, the best way to think about this is to split only when we might not need something.
For instance, in the above case we were splitting into 6 chunks sections of the same page that are always immediately loaded when the page is visited. In this case we could consider it as a single "UI island" that can be dynamically loaded at once, reducing the back and forth with the server.
The flyout example you are doing is a good one, as the user might never open the flyout during a session.
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
tonyghiani
added
the
backport:prev-minor
botelastic
bot
added
the
ci:project-deploy-observability
yngrdyn
approved these changes
Oct 2, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
…tic#194661) ## 📓 Summary Closes elastic#191602 This work reduces the initial bundle size for the dataset quality plugin by **~55%** and reduces fragmentation in the chunks when the main page loads. | Before | After | |--------|--------| | <img width="525" alt="Screenshot 2024-10-02 at 09 56 35" src="https://github.com/user-attachments/assets/06fec02c-ff2c-4771-981f-a761bda67eae"> | <img width="521" alt="Screenshot 2024-10-02 at 09 59 16" src="https://github.com/user-attachments/assets/a243b09a-9d83-4d0d-b875-20855bb18f5d"> | | <img width="1398" alt="Screenshot 2024-10-02 at 09 56 55" src="https://github.com/user-attachments/assets/66d2c131-b0b7-47e1-9a9a-e1be57e69bbb"> | <img width="678" alt="Screenshot 2024-10-02 at 09 58 59" src="https://github.com/user-attachments/assets/39e6515e-5a83-4d97-97c8-cce01b7c6887"> | Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit ce8c9d8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
…#194661) (#194746) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Optimize bundle size and chunks fragmentation (#194661)](#194661) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-02T16:37:04Z","message":"[Dataset Quality] Optimize bundle size and chunks fragmentation (#194661)\n\n## 📓 Summary\r\n\r\nCloses #191602 \r\n\r\nThis work reduces the initial bundle size for the dataset quality plugin\r\nby **~55%** and reduces fragmentation in the chunks when the main page\r\nloads.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n| <img width=\"525\" alt=\"Screenshot 2024-10-02 at 09 56 35\"\r\nsrc=\"https://github.com/user-attachments/assets/06fec02c-ff2c-4771-981f-a761bda67eae\">\r\n| <img width=\"521\" alt=\"Screenshot 2024-10-02 at 09 59 16\"\r\nsrc=\"https://github.com/user-attachments/assets/a243b09a-9d83-4d0d-b875-20855bb18f5d\">\r\n|\r\n| <img width=\"1398\" alt=\"Screenshot 2024-10-02 at 09 56 55\"\r\nsrc=\"https://github.com/user-attachments/assets/66d2c131-b0b7-47e1-9a9a-e1be57e69bbb\">\r\n| <img width=\"678\" alt=\"Screenshot 2024-10-02 at 09 58 59\"\r\nsrc=\"https://github.com/user-attachments/assets/39e6515e-5a83-4d97-97c8-cce01b7c6887\">\r\n|\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"ce8c9d8d63ac8d67e975f4cd15cdb665a064d67e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset Quality] Optimize bundle size and chunks fragmentation","number":194661,"url":"https://github.com/elastic/kibana/pull/194661","mergeCommit":{"message":"[Dataset Quality] Optimize bundle size and chunks fragmentation (#194661)\n\n## 📓 Summary\r\n\r\nCloses #191602 \r\n\r\nThis work reduces the initial bundle size for the dataset quality plugin\r\nby **~55%** and reduces fragmentation in the chunks when the main page\r\nloads.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n| <img width=\"525\" alt=\"Screenshot 2024-10-02 at 09 56 35\"\r\nsrc=\"https://github.com/user-attachments/assets/06fec02c-ff2c-4771-981f-a761bda67eae\">\r\n| <img width=\"521\" alt=\"Screenshot 2024-10-02 at 09 59 16\"\r\nsrc=\"https://github.com/user-attachments/assets/a243b09a-9d83-4d0d-b875-20855bb18f5d\">\r\n|\r\n| <img width=\"1398\" alt=\"Screenshot 2024-10-02 at 09 56 55\"\r\nsrc=\"https://github.com/user-attachments/assets/66d2c131-b0b7-47e1-9a9a-e1be57e69bbb\">\r\n| <img width=\"678\" alt=\"Screenshot 2024-10-02 at 09 58 59\"\r\nsrc=\"https://github.com/user-attachments/assets/39e6515e-5a83-4d97-97c8-cce01b7c6887\">\r\n|\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"ce8c9d8d63ac8d67e975f4cd15cdb665a064d67e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194661","number":194661,"mergeCommit":{"message":"[Dataset Quality] Optimize bundle size and chunks fragmentation (#194661)\n\n## 📓 Summary\r\n\r\nCloses #191602 \r\n\r\nThis work reduces the initial bundle size for the dataset quality plugin\r\nby **~55%** and reduces fragmentation in the chunks when the main page\r\nloads.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n| <img width=\"525\" alt=\"Screenshot 2024-10-02 at 09 56 35\"\r\nsrc=\"https://github.com/user-attachments/assets/06fec02c-ff2c-4771-981f-a761bda67eae\">\r\n| <img width=\"521\" alt=\"Screenshot 2024-10-02 at 09 59 16\"\r\nsrc=\"https://github.com/user-attachments/assets/a243b09a-9d83-4d0d-b875-20855bb18f5d\">\r\n|\r\n| <img width=\"1398\" alt=\"Screenshot 2024-10-02 at 09 56 55\"\r\nsrc=\"https://github.com/user-attachments/assets/66d2c131-b0b7-47e1-9a9a-e1be57e69bbb\">\r\n| <img width=\"678\" alt=\"Screenshot 2024-10-02 at 09 58 59\"\r\nsrc=\"https://github.com/user-attachments/assets/39e6515e-5a83-4d97-97c8-cce01b7c6887\">\r\n|\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"ce8c9d8d63ac8d67e975f4cd15cdb665a064d67e"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #191602
This work reduces the initial bundle size for the dataset quality plugin by ~55% and reduces fragmentation in the chunks when the main page loads.