[Enterprise Search] Adds Callout for Upcoming Decommissioning of App Search and Workplace Search #194363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
markjhoy
added
backport:skip
| blogUrl: ( | ||
| <EuiLink | ||
| data-test-subj="workplaceSearch-deprecationCallout-blog-link" | ||
| href="https://www.elastic.co/search-labs/blog/evolution-app-search-elasticsearch" |
There was a problem hiding this comment.
should this be in a doc link instead of hard-coded?
There was a problem hiding this comment.
They could, but I was under the impression those links were tied to actual documentation, and not Search Labs blogs, no? Regardless - where do these links get populated? I can't seem to find it in the code...
There was a problem hiding this comment.
Thanks again @TattdCodeMonkey - this latest commit should do the trick.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
TattdCodeMonkey
approved these changes
Oct 10, 2024
4 tasks
markjhoy
added a commit
that referenced
this pull request
Oct 15, 2024
… Empty State (#196337) ## Summary Light cleanup of the callout for adding margins, and also adds the callout to the Users and Roles in App Search empty state. This is a follow-on to #194363  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a callout to the overview pages for App Search and Workplace Search, informing the user of the updating decommissioning of the Enterprise Search product. Once the user clicks the "Dismiss" link, or the "x" button (upper-right), the callout will not be shown again until the user logs back in from a new tab or window. Note that the flag to show the callout or not is independent of the product (i.e. dismissing the callout in App Search will still show the callout in Workplace Search, until that one is dismissed as well).
(Note that the link provided to the App Search (catalog) blog post is the correct URL, but the actual post will be forthcoming before the release)
Checklist
For maintainers