[Enterprise Search] Cleanups for Deprecation Callout and Add to Roles Empty State #196337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjhoy
added
release_note:skip
leemthompo
reviewed
Oct 15, 2024
| > | ||
| <FormattedMessage | ||
| id="xpack.enterpriseSearch.deprecationCallout.first_message" | ||
| defaultMessage="The standalone App Search and Workplace Search products remain available in maintenance mode, and are not recommended for new search experiences. Instead, we recommend using our Elasticsearch-native tools which we are actively developing and improving, for your search use cases. These tools offer the flexibility and composability of working directly with Elasticsearch indices." |
There was a problem hiding this comment.
Suggested change
| defaultMessage="The standalone App Search and Workplace Search products remain available in maintenance mode, and are not recommended for new search experiences. Instead, we recommend using our Elasticsearch-native tools which we are actively developing and improving, for your search use cases. These tools offer the flexibility and composability of working directly with Elasticsearch indices." | |
| defaultMessage="The standalone App Search and Workplace Search products remain available in maintenance mode, but are not recommended for new search experiences. Instead, we recommend using our actively developed Elasticsearch-native tools. These tools offer the flexibility and composability of working directly with Elasticsearch indices." |
There was a problem hiding this comment.
Thanks! Updated now with the latest commit.
|
@markjhoy small nit - could we please say |
| > | ||
| <FormattedMessage | ||
| id="xpack.enterpriseSearch.deprecationCallout.first_message" | ||
| defaultMessage="The standalone App Search and Workplace Search products remain available in maintenance mode, but are not recommended for new search experiences. Instead, we recommend using our actively developed Elasticsearch-native tools. These tools offer the flexibility and composability of working directly with Elasticsearch indices." |
There was a problem hiding this comment.
Oh, and I just saw that we're not mentioning Enterprise search
"The standalone Enterprise Search product, including App Search, and Workplace Search"
since the hosted web crawler will be a breaking change in 9.0, I think we should include Enterprise Search in the messaging
Where at in the message? And any specific text? |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kderusso
approved these changes
Oct 15, 2024
| > | ||
| {i18n.translate('xpack.enterpriseSearch.deprecationCallout.viewAppSearchBlog', { | ||
| defaultMessage: 'blog post', | ||
| {i18n.translate('xpack.enterpriseSearch.deprecationCallout.dissmissLink', { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Light cleanup of the callout for adding margins, and also adds the callout to the Users and Roles in App Search empty state.
This is a follow-on to #194363
Checklist
For maintainers