[8.x] [ML] Move FieldStatsFlyout, parseInterval, validators to packages. (#193657) #193859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#193657) ## Summary Part of elastic#159917. Moves code from `plugins/ml/common|public` to packages that is used by transforms too. While the transforms plugin is maintained by the ML team too, the transform plugin itself is independently available from the ML UI in the Kibana management section. We should try to avoid that the transform plugin is directly depending on the `ml` plugin. This PR moves some code from `plugins/ml/common|public` to packages so that we can remove `ml` from the list of `requiredBundles` of the `transform` plugin. The packages were created with these commands: ``` node scripts/generate package @kbn/ml-field-stats-flyout --dir ./x-pack/packages/ml/field_stats_flyout node scripts/generate package @kbn/ml-parse-interval --dir ./x-pack/packages/ml/parse_interval node scripts/generate package @kbn/ml-validators --dir ./x-pack/packages/ml/validators ``` The following commands were used to check missing jsdoc comments and exports: ``` node scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats comments node scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats exports node scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats comments node scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats exports node scripts/build_api_docs --plugin @kbn/ml-validators --stats comments node scripts/build_api_docs --plugin @kbn/ml-validators --stats exports ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit b2d85d5) # Conflicts: # .github/CODEOWNERS
3 tasks
rbrtj
approved these changes
Sep 24, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @walterra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation