[ML] Move FieldStatsFlyout, parseInterval, validators to packages. #193657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-field-stats-flyout-package
branch
2 times, most recently
from
f8f0e13 to
137f975
Compare
walterra
force-pushed
the
ml-field-stats-flyout-package
branch
from
137f975 to
da4f7a4
Compare
walterra
changed the title
walterra
force-pushed
the
ml-field-stats-flyout-package
branch
from
b305119 to
93103b4
Compare
walterra
added
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
8 tasks
jloleysens
approved these changes
Sep 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
peteharverson
approved these changes
Sep 24, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 24, 2024
…lastic#193657) ## Summary Part of elastic#159917. Moves code from `plugins/ml/common|public` to packages that is used by transforms too. While the transforms plugin is maintained by the ML team too, the transform plugin itself is independently available from the ML UI in the Kibana management section. We should try to avoid that the transform plugin is directly depending on the `ml` plugin. This PR moves some code from `plugins/ml/common|public` to packages so that we can remove `ml` from the list of `requiredBundles` of the `transform` plugin. The packages were created with these commands: ``` node scripts/generate package @kbn/ml-field-stats-flyout --dir ./x-pack/packages/ml/field_stats_flyout node scripts/generate package @kbn/ml-parse-interval --dir ./x-pack/packages/ml/parse_interval node scripts/generate package @kbn/ml-validators --dir ./x-pack/packages/ml/validators ``` The following commands were used to check missing jsdoc comments and exports: ``` node scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats comments node scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats exports node scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats comments node scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats exports node scripts/build_api_docs --plugin @kbn/ml-validators --stats comments node scripts/build_api_docs --plugin @kbn/ml-validators --stats exports ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit b2d85d5) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
walterra
added a commit
that referenced
this pull request
Sep 24, 2024
…es. (#193657) (#193859) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Move FieldStatsFlyout, parseInterval, validators to packages. (#193657)](#193657) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T12:00:55Z","message":"[ML] Move FieldStatsFlyout, parseInterval, validators to packages. (#193657)\n\n## Summary\r\n\r\nPart of #159917.\r\n\r\nMoves code from `plugins/ml/common|public` to packages that is used by\r\ntransforms too.\r\n\r\nWhile the transforms plugin is maintained by the ML team too, the\r\ntransform plugin itself is independently available from the ML UI in the\r\nKibana management section. We should try to avoid that the transform\r\nplugin is directly depending on the `ml` plugin. This PR moves some code\r\nfrom `plugins/ml/common|public` to packages so that we can remove `ml`\r\nfrom the list of `requiredBundles` of the `transform` plugin.\r\n\r\nThe packages were created with these commands:\r\n\r\n```\r\nnode scripts/generate package @kbn/ml-field-stats-flyout --dir ./x-pack/packages/ml/field_stats_flyout\r\nnode scripts/generate package @kbn/ml-parse-interval --dir ./x-pack/packages/ml/parse_interval\r\nnode scripts/generate package @kbn/ml-validators --dir ./x-pack/packages/ml/validators\r\n```\r\n\r\nThe following commands were used to check missing jsdoc comments and\r\nexports:\r\n\r\n```\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats exports\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b2d85d5f8f10f7c460c3a3b732844a19c8b20d7b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Transforms","v9.0.0","backport:prev-minor","v8.16.0"],"number":193657,"url":"https://github.com/elastic/kibana/pull/193657","mergeCommit":{"message":"[ML] Move FieldStatsFlyout, parseInterval, validators to packages. (#193657)\n\n## Summary\r\n\r\nPart of #159917.\r\n\r\nMoves code from `plugins/ml/common|public` to packages that is used by\r\ntransforms too.\r\n\r\nWhile the transforms plugin is maintained by the ML team too, the\r\ntransform plugin itself is independently available from the ML UI in the\r\nKibana management section. We should try to avoid that the transform\r\nplugin is directly depending on the `ml` plugin. This PR moves some code\r\nfrom `plugins/ml/common|public` to packages so that we can remove `ml`\r\nfrom the list of `requiredBundles` of the `transform` plugin.\r\n\r\nThe packages were created with these commands:\r\n\r\n```\r\nnode scripts/generate package @kbn/ml-field-stats-flyout --dir ./x-pack/packages/ml/field_stats_flyout\r\nnode scripts/generate package @kbn/ml-parse-interval --dir ./x-pack/packages/ml/parse_interval\r\nnode scripts/generate package @kbn/ml-validators --dir ./x-pack/packages/ml/validators\r\n```\r\n\r\nThe following commands were used to check missing jsdoc comments and\r\nexports:\r\n\r\n```\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats exports\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b2d85d5f8f10f7c460c3a3b732844a19c8b20d7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193657","number":193657,"mergeCommit":{"message":"[ML] Move FieldStatsFlyout, parseInterval, validators to packages. (#193657)\n\n## Summary\r\n\r\nPart of #159917.\r\n\r\nMoves code from `plugins/ml/common|public` to packages that is used by\r\ntransforms too.\r\n\r\nWhile the transforms plugin is maintained by the ML team too, the\r\ntransform plugin itself is independently available from the ML UI in the\r\nKibana management section. We should try to avoid that the transform\r\nplugin is directly depending on the `ml` plugin. This PR moves some code\r\nfrom `plugins/ml/common|public` to packages so that we can remove `ml`\r\nfrom the list of `requiredBundles` of the `transform` plugin.\r\n\r\nThe packages were created with these commands:\r\n\r\n```\r\nnode scripts/generate package @kbn/ml-field-stats-flyout --dir ./x-pack/packages/ml/field_stats_flyout\r\nnode scripts/generate package @kbn/ml-parse-interval --dir ./x-pack/packages/ml/parse_interval\r\nnode scripts/generate package @kbn/ml-validators --dir ./x-pack/packages/ml/validators\r\n```\r\n\r\nThe following commands were used to check missing jsdoc comments and\r\nexports:\r\n\r\n```\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-field-stats-flyout --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-parse-interval --stats exports\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats comments\r\nnode scripts/build_api_docs --plugin @kbn/ml-validators --stats exports\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b2d85d5f8f10f7c460c3a3b732844a19c8b20d7b"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
3 tasks
walterra
added a commit
that referenced
this pull request
Oct 2, 2024
…ut (#194517) ## Summary Part of #187772. Follow up to #193657. The previous PR #193657 moved `FieldStatsFlyout` to a package, the `aiops` plugin didn't make full use of that refactor by still passing in the flyout into the app context. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
…ut (elastic#194517) ## Summary Part of elastic#187772. Follow up to elastic#193657. The previous PR elastic#193657 moved `FieldStatsFlyout` to a package, the `aiops` plugin didn't make full use of that refactor by still passing in the flyout into the app context. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit eebfba4)
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
…s flyout (#194517) (#194710) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Use package instead of context for using field stats flyout (#194517)](#194517) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-02T13:23:23Z","message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version"],"title":"[ML] AIOps: Use package instead of context for using field stats flyout","number":194517,"url":"https://github.com/elastic/kibana/pull/194517","mergeCommit":{"message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194517","number":194517,"mergeCommit":{"message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #159917.
Moves code from
plugins/ml/common|publicto packages that is used by transforms too.While the transforms plugin is maintained by the ML team too, the transform plugin itself is independently available from the ML UI in the Kibana management section. We should try to avoid that the transform plugin is directly depending on the
mlplugin. This PR moves some code fromplugins/ml/common|publicto packages so that we can removemlfrom the list ofrequiredBundlesof thetransformplugin.The packages were created with these commands:
The following commands were used to check missing jsdoc comments and exports:
Checklist