[Security Solution][Notes] - fix column width on events table on host, user and network pages #193460
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, user and network pages
PhilippeOberti
added
backport
v9.0.0
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
janmonschke
approved these changes
Sep 20, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
…, user and network pages (elastic#193460) (cherry picked from commit 2a98d1a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…n host, user and network pages (#193460) (#193580) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - fix column width on events table on host, user and network pages (#193460)](#193460) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T13:38:05Z","message":"[Security Solution][Notes] - fix column width on events table on host, user and network pages (#193460)","sha":"2a98d1af37ca8aca570b3c44728087b6271c3444","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - fix column width on events table on host, user and network pages","number":193460,"url":"https://github.com/elastic/kibana/pull/193460","mergeCommit":{"message":"[Security Solution][Notes] - fix column width on events table on host, user and network pages (#193460)","sha":"2a98d1af37ca8aca570b3c44728087b6271c3444"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193460","number":193460,"mergeCommit":{"message":"[Security Solution][Notes] - fix column width on events table on host, user and network pages (#193460)","sha":"2a98d1af37ca8aca570b3c44728087b6271c3444"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small bug on the events table on the Explore host, user and network pages.
As can be seen in the screenshot below, the actions column width is not correct when the
securitySolutionNotesEnabledfeature flag is enabled inmain(we're missing the session view icon)This branch increases the width to make room for the notes button when the
securitySolutionNotesEnabledfeature flag is enabledAnd this is the normal width when the feature flag is not enabled
#193088