Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR][Ownership] add @elastic/response-ops to es archives #193449

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Sep 19, 2024

Summary

Modify code owner declarations for @elastic/response-ops team in .github/CODEOWNERS

Update for Reviewers

With the merge of this, you can now do this:
node scripts/get_owners_for_file.js --file x-pack/test/functional/es_archives/action_task_params

 succ elastic/response-ops

So, you can use this script to see if the code owners file is reporting erroneously

For Reviewers

Added these lines:

/x-pack/test/functional/es_archives/actions @elastic/response-ops
/x-pack/test/functional/es_archives/alerting @elastic/response-ops
/x-pack/test/functional/es_archives/alerts @elastic/response-ops
/x-pack/test/functional/es_archives/alerts_legacy @elastic/response-ops
/x-pack/test/functional/es_archives/observability/alerts @elastic/response-ops
/x-pack/test/functional/es_archives/actions @elastic/response-ops
/x-pack/test/functional/es_archives/rules_scheduled_task_id  @elastic/response-ops
/x-pack/test/functional/es_archives/alerting/8_2_0  @elastic/response-ops

Most of these changes come from searching for esArchiver.load, within x-pack/test/alerting_api_integration
Obviously this can easily be erroneous, so please keep me honest.

Notes

This is a best guess effort, as we march towards having zero files within test && x-pack/test && x-pack/test_serverless without a code owner.

In the end, this will contribute to better reporting.

Contribues to: #192979

@wayneseymour wayneseymour self-assigned this Sep 19, 2024
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 19, 2024
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour wayneseymour requested review from pmuellr and removed request for pgayvallet September 20, 2024 13:25
@wayneseymour wayneseymour changed the title [FTR][Ownership] add response ops to es archives [FTR][Ownership] add @elastic/response-ops to es archives Sep 20, 2024
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit d30b9c8 into elastic:main Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants