-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTR][Ownership] add @elastic/response-ops to es archives #193449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
labels
Sep 19, 2024
@elasticmachine merge upstream |
6 tasks
@elasticmachine merge upstream |
@elasticmachine merge upstream |
wayneseymour
requested review from
pmuellr
and removed request for
pgayvallet
September 20, 2024 13:25
wayneseymour
changed the title
[FTR][Ownership] add response ops to es archives
[FTR][Ownership] add @elastic/response-ops to es archives
Sep 20, 2024
pmuellr
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify code owner declarations for @elastic/response-ops team in
.github/CODEOWNERS
Update for Reviewers
With the merge of this, you can now do this:
node scripts/get_owners_for_file.js --file x-pack/test/functional/es_archives/action_task_params
So, you can use this script to see if the code owners file is reporting erroneously
For Reviewers
Added these lines:
Most of these changes come from searching for
esArchiver.load
, withinx-pack/test/alerting_api_integration
Obviously this can easily be erroneous, so please keep me honest.
Notes
This is a best guess effort, as we march towards having zero files within
test
&&x-pack/test
&&x-pack/test_serverless
without a code owner.In the end, this will contribute to better reporting.
Contribues to: #192979