[Infra] Amend inventory title to "Infrastructure Inventory" #193189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluefinger
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Bluefinger
commented
Sep 18, 2024
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
|
@elasticmachine merge upstream |
cauemarcondes
approved these changes
Sep 19, 2024
crespocarlos
added
backport:prev-minor
crespocarlos
approved these changes
Sep 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
tonyghiani
approved these changes
Sep 20, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
…193189) ## Summary Update the Inventory title terminology to be "Infrastructure Inventory", in order to differentiate from the incoming top-level "Inventory" page. <img width="481" alt="Screenshot 2024-09-17 170745" src="https://github.com/user-attachments/assets/d72dfb6e-fe3b-44d8-b6f0-ae333586ceb4"> Closes elastic#192324 # How to test - Load Elastic cluster, go to Infrastructure -> Infrastructure Inventory **Expected**: The side menu link text should match the breadcrumb title and the main title text for the page. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 04c3486)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…" (#193189) (#193523) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Amend inventory title to "Infrastructure Inventory" (#193189)](#193189) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T09:41:47Z","message":"[Infra] Amend inventory title to \"Infrastructure Inventory\" (#193189)\n\n## Summary\r\n\r\nUpdate the Inventory title terminology to be \"Infrastructure Inventory\",\r\nin order to differentiate from the incoming top-level \"Inventory\" page.\r\n\r\n<img width=\"481\" alt=\"Screenshot 2024-09-17 170745\"\r\nsrc=\"https://github.com/user-attachments/assets/d72dfb6e-fe3b-44d8-b6f0-ae333586ceb4\">\r\n\r\nCloses #192324 \r\n\r\n# How to test\r\n\r\n- Load Elastic cluster, go to Infrastructure -> Infrastructure Inventory\r\n\r\n**Expected**: The side menu link text should match the breadcrumb title\r\nand the main title text for the page.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"04c3486878efed32e99fd4d17c893f69a10ed9ab","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Infra] Amend inventory title to \"Infrastructure Inventory\"","number":193189,"url":"https://github.com/elastic/kibana/pull/193189","mergeCommit":{"message":"[Infra] Amend inventory title to \"Infrastructure Inventory\" (#193189)\n\n## Summary\r\n\r\nUpdate the Inventory title terminology to be \"Infrastructure Inventory\",\r\nin order to differentiate from the incoming top-level \"Inventory\" page.\r\n\r\n<img width=\"481\" alt=\"Screenshot 2024-09-17 170745\"\r\nsrc=\"https://github.com/user-attachments/assets/d72dfb6e-fe3b-44d8-b6f0-ae333586ceb4\">\r\n\r\nCloses #192324 \r\n\r\n# How to test\r\n\r\n- Load Elastic cluster, go to Infrastructure -> Infrastructure Inventory\r\n\r\n**Expected**: The side menu link text should match the breadcrumb title\r\nand the main title text for the page.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"04c3486878efed32e99fd4d17c893f69a10ed9ab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193189","number":193189,"mergeCommit":{"message":"[Infra] Amend inventory title to \"Infrastructure Inventory\" (#193189)\n\n## Summary\r\n\r\nUpdate the Inventory title terminology to be \"Infrastructure Inventory\",\r\nin order to differentiate from the incoming top-level \"Inventory\" page.\r\n\r\n<img width=\"481\" alt=\"Screenshot 2024-09-17 170745\"\r\nsrc=\"https://github.com/user-attachments/assets/d72dfb6e-fe3b-44d8-b6f0-ae333586ceb4\">\r\n\r\nCloses #192324 \r\n\r\n# How to test\r\n\r\n- Load Elastic cluster, go to Infrastructure -> Infrastructure Inventory\r\n\r\n**Expected**: The side menu link text should match the breadcrumb title\r\nand the main title text for the page.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"04c3486878efed32e99fd4d17c893f69a10ed9ab"}}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Inventory title terminology to be "Infrastructure Inventory", in order to differentiate from the incoming top-level "Inventory" page.
Closes #192324
How to test
Expected: The side menu link text should match the breadcrumb title and the main title text for the page.