Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge #193182

Merged
merged 4 commits into from
Sep 17, 2024
Merged

[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge #193182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe21fc
Add tech preview beta badge to Agent Type integration component
paul-tavares Sep 17, 2024
7befbf2
Remove beta/Tech preview badge from Responder page title
paul-tavares Sep 17, 2024
a642c49
update detection isolate flyout header and remove tech preview badge
paul-tavares Sep 17, 2024
e7f9b16
tests for AgentTypeIntegration component
paul-tavares Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .../common/components/endpoint/agents/agent_type_integration/agent_type_integration.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,19 @@ describe('AgentTypeIntegration component', () => {

expect(getByTestId('test-tooltipAnchor'));
});

if (agentType === 'sentinel_one' || agentType === 'crowdstrike') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for adding the tests as well!!

it('should display tech preview badge', () => {
const { getByTestId } = render();

expect(getByTestId('test-betaBadge')).not.toBeNull();
});
} else {
it('should NOT display tech preview badge', () => {
const { queryByTestId } = render();

expect(queryByTestId('test-betaBadge')).toBeNull();
});
}
});
});
25 changes: 22 additions & 3 deletions ...ublic/common/components/endpoint/agents/agent_type_integration/agent_type_integration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,18 @@
* 2.0.
*/

import React, { memo } from 'react';
import React, { memo, useMemo } from 'react';
import type { EuiTextProps } from '@elastic/eui';
import { EuiFlexGroup, EuiFlexItem, EuiIconTip, EuiText } from '@elastic/eui';
import { EuiBetaBadge, EuiFlexGroup, EuiFlexItem, EuiIconTip, EuiText } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { i18n } from '@kbn/i18n';
import { useTestIdGenerator } from '../../../../../management/hooks/use_test_id_generator';
import { AgentTypeVendorLogo } from '../agent_type_vendor_logo';
import { getAgentTypeName } from '../../../../translations';
import {
getAgentTypeName,
TECHNICAL_PREVIEW,
TECHNICAL_PREVIEW_TOOLTIP,
} from '../../../../translations';
import type { ResponseActionAgentType } from '../../../../../../common/endpoint/service/response_actions/constants';

export const INTEGRATION_SECTION_LABEL = i18n.translate(
Expand All @@ -38,6 +42,10 @@ export const AgentTypeIntegration = memo<AgentTypeIntegrationProps>(
({ agentType, textSize = 's', layout = 'vertical', 'data-test-subj': dataTestSubj }) => {
const testId = useTestIdGenerator(dataTestSubj);

const isTechPreview = useMemo(() => {
return agentType === 'sentinel_one' || agentType === 'crowdstrike';
}, [agentType]);

return (
<EuiFlexGroup
direction={layout === 'horizontal' ? 'row' : 'column'}
Expand Down Expand Up @@ -69,6 +77,17 @@ export const AgentTypeIntegration = memo<AgentTypeIntegrationProps>(
{getAgentTypeName(agentType)}
</EuiText>
</EuiFlexItem>
{isTechPreview && (
<EuiFlexItem grow={false}>
<EuiBetaBadge
label={TECHNICAL_PREVIEW}
tooltipContent={TECHNICAL_PREVIEW_TOOLTIP}
iconType="beaker"
size="s"
data-test-subj={testId('betaBadge')}
/>
</EuiFlexItem>
)}
</EuiFlexGroup>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
18 changes: 2 additions & 16 deletions x-pack/plugins/security_solution/public/flyout/document_details/isolate_host/header.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { createAppRootMockRenderer, endpointAlertDataMock } from '../../../commo
import type { ResponseActionAgentType } from '../../../../common/endpoint/service/response_actions/constants';
import { RESPONSE_ACTION_AGENT_TYPE } from '../../../../common/endpoint/service/response_actions/constants';
import { ISOLATE_HOST, UNISOLATE_HOST } from '../../../common/components/endpoint/host_isolation';
import { TECHNICAL_PREVIEW } from '../../../common/translations';

jest.mock('./context');

Expand Down Expand Up @@ -58,8 +57,6 @@ describe('Isolation Flyout PanelHeader', () => {
action: IsolateHostPanelContext['isolateAction'];
agentType: ResponseActionAgentType;
title: string;
// if `expectedBadgeText` is `undefined`, then it validates that the badge is not displayed
expectedBadgeText: string | undefined;
}> = [];

for (const agentType of RESPONSE_ACTION_AGENT_TYPE) {
Expand All @@ -69,33 +66,22 @@ describe('Isolation Flyout PanelHeader', () => {
action,
agentType,
title: action === 'isolateHost' ? ISOLATE_HOST : UNISOLATE_HOST,
expectedBadgeText:
agentType === 'crowdstrike' || agentType === 'sentinel_one'
? TECHNICAL_PREVIEW
: undefined,
});
}
);
}

it.each(testConditions)(
'should display correct flyout header title for $action on agentType $agentType',
({ action, agentType, title, expectedBadgeText }) => {
({ action, agentType, title }) => {
setUseIsolateHostPanelContext({
isolateAction: action,
dataFormattedForFieldBrowser:
endpointAlertDataMock.generateAlertDetailsItemDataForAgentType(agentType),
});
const { getByTestId, queryByTestId } = render();
const { getByTestId } = render();

expect(getByTestId('flyoutHostIsolationHeaderTitle')).toHaveTextContent(title);

if (expectedBadgeText) {
expect(getByTestId('flyoutHostIsolationHeaderBadge')).toHaveTextContent(expectedBadgeText);
} else {
expect(queryByTestId('flyoutHostIsolationHeaderBadge')).toBeNull();
}

expect(getByTestId('flyoutHostIsolationHeaderIntegration'));
}
);
Expand Down
19 changes: 2 additions & 17 deletions x-pack/plugins/security_solution/public/flyout/document_details/isolate_host/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
* 2.0.
*/

import { EuiBetaBadge, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui';
import { EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui';
import type { FC } from 'react';
import React, { useMemo } from 'react';
import React from 'react';
import { FlyoutHeader } from '@kbn/security-solution-common';
import { AgentTypeIntegration } from '../../../common/components/endpoint/agents/agent_type_integration';
import { useAlertResponseActionsSupport } from '../../../common/hooks/endpoint/use_alert_response_actions_support';
import { TECHNICAL_PREVIEW, TECHNICAL_PREVIEW_TOOLTIP } from '../../../common/translations';
import { useIsolateHostPanelContext } from './context';
import { FLYOUT_HEADER_TITLE_TEST_ID } from './test_ids';
import { ISOLATE_HOST, UNISOLATE_HOST } from '../../../common/components/endpoint';
Expand All @@ -22,14 +21,9 @@ import { ISOLATE_HOST, UNISOLATE_HOST } from '../../../common/components/endpoin
export const PanelHeader: FC = () => {
const { isolateAction, dataFormattedForFieldBrowser: data } = useIsolateHostPanelContext();
const {
isSupported: supportsResponseActions,
details: { agentType },
} = useAlertResponseActionsSupport(data);

const showTechPreviewBadge: boolean = useMemo(() => {
return supportsResponseActions && (agentType === 'sentinel_one' || agentType === 'crowdstrike');
}, [agentType, supportsResponseActions]);

const title = (
<EuiFlexGroup responsive gutterSize="s">
<EuiFlexItem grow={false} data-test-subj="flyoutHostIsolationHeaderTitle">
Expand All @@ -41,15 +35,6 @@ export const PanelHeader: FC = () => {
data-test-subj="flyoutHostIsolationHeaderIntegration"
/>
</EuiFlexItem>
{showTechPreviewBadge && (
<EuiFlexItem grow={false}>
<EuiBetaBadge
data-test-subj="flyoutHostIsolationHeaderBadge"
label={TECHNICAL_PREVIEW}
tooltipContent={TECHNICAL_PREVIEW_TOOLTIP}
/>
</EuiFlexItem>
)}
</EuiFlexGroup>
);

Expand Down
33 changes: 1 addition & 32 deletions x-pack/plugins/security_solution/public/management/hooks/use_with_show_responder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
*/

import React, { useCallback } from 'react';
import { EuiBetaBadge, EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import { TECHNICAL_PREVIEW, TECHNICAL_PREVIEW_TOOLTIP } from '../../common/translations';
import { useLicense } from '../../common/hooks/use_license';
import type { MaybeImmutable } from '../../../common/endpoint/types';
import type { EndpointCapabilities } from '../../../common/endpoint/service/response_actions/constants';
Expand All @@ -23,7 +21,6 @@ import {
import { useConsoleManager } from '../components/console';
import { MissingEncryptionKeyCallout } from '../components/missing_encryption_key_callout';
import { RESPONDER_PAGE_TITLE } from './translations';
import { useIsExperimentalFeatureEnabled } from '../../common/hooks/use_experimental_features';

type ShowResponseActionsConsole = (props: ResponderInfoProps) => void;

Expand All @@ -47,19 +44,10 @@ export const useWithShowResponder = (): ShowResponseActionsConsole => {
const consoleManager = useConsoleManager();
const endpointPrivileges = useUserPrivileges().endpointPrivileges;
const isEnterpriseLicense = useLicense().isEnterprise();
const isSentinelOneV1Enabled = useIsExperimentalFeatureEnabled(
'responseActionsSentinelOneV1Enabled'
);
const responseActionsCrowdstrikeManualHostIsolationEnabled = useIsExperimentalFeatureEnabled(
'responseActionsCrowdstrikeManualHostIsolationEnabled'
);

return useCallback(
(props: ResponderInfoProps) => {
const { agentId, agentType, capabilities, hostName, platform } = props;
const isExternalEdr =
(isSentinelOneV1Enabled && agentType === 'sentinel_one') ||
(responseActionsCrowdstrikeManualHostIsolationEnabled && agentType === 'crowdstrike');

// If no authz, just exit and log something to the console
if (agentType === 'endpoint' && !endpointPrivileges.canAccessResponseConsole) {
Expand Down Expand Up @@ -109,19 +97,6 @@ export const useWithShowResponder = (): ShowResponseActionsConsole => {
},
consoleProps,
PageTitleComponent: () => {
if (isExternalEdr) {
return (
<EuiFlexGroup>
<EuiFlexItem>{RESPONDER_PAGE_TITLE}</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiBetaBadge
label={TECHNICAL_PREVIEW}
tooltipContent={TECHNICAL_PREVIEW_TOOLTIP}
/>
</EuiFlexItem>
</EuiFlexGroup>
);
}
return <>{RESPONDER_PAGE_TITLE}</>;
},
ActionComponents: endpointPrivileges.canReadActionsLogManagement
Expand All @@ -141,12 +116,6 @@ export const useWithShowResponder = (): ShowResponseActionsConsole => {
.show();
}
},
[
isSentinelOneV1Enabled,
responseActionsCrowdstrikeManualHostIsolationEnabled,
endpointPrivileges,
isEnterpriseLicense,
consoleManager,
]
[endpointPrivileges, isEnterpriseLicense, consoleManager]
);
};