[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge #193182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💛 Build succeeded, but was flaky
Failed CI StepsThe CI Stats report is too large to be displayed here, check out the CI build annotation for this information. To update your PR or re-run it, just comment with: |
ashokaditya
approved these changes
Sep 17, 2024
| @@ -51,5 +51,19 @@ describe('AgentTypeIntegration component', () => { | |||
|
|
|||
| expect(getByTestId('test-tooltipAnchor')); | |||
| }); | |||
|
|
|||
| if (agentType === 'sentinel_one' || agentType === 'crowdstrike') { | |||
There was a problem hiding this comment.
🔥 Thanks for adding the tests as well!!
paul-tavares
deleted the
task/olm-10607-change-to-console-tech-preview-icon
branch
|
@ashokaditya - thanks for the review. You are correct on the icon being a bit higher than the other icons. Its actually because its size is smaller. I found that it did not look that good with the icon being the same size as the integration vendor icon, so I used |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 17, 2024
…h. Preview badge (elastic#193182) ## Summary PR updates the Response Console and Isolate/Release flyouts with: - Removes the "Technical Preview" badge from the page/flyout title - Adds [EUI's Beta badge](https://eui.elastic.co/#/display/badge#beta-badge-type) to the Agent Type Integration with labels of "Technical Preview" ___________ #### Response Console |Display|Hover on icon| |------|------| |<img width="716" alt="image" src="https://github.com/user-attachments/assets/838a7609-aaa2-439b-98d6-09cce2d1c4b4">|<img width="835" alt="image" src="https://github.com/user-attachments/assets/948a0516-31dd-456b-8025-3a5a79dd7815">| #### Isolate/Release Flyout |Display|Hover on icon| |------|------| |<img width="800" alt="image" src="https://github.com/user-attachments/assets/01767b5d-4e4c-403b-a31b-ae7c960a5288">|<img width="799" alt="image" src="https://github.com/user-attachments/assets/577b0513-6a5d-486c-bcd3-38541022a818">| #### Elastic Defend (no tech preview badge) |Responder|Isolation panel from alerts| |------|------| |<img width="757" alt="image" src="https://github.com/user-attachments/assets/a5de5be5-2e04-4d8c-8c32-139b155fba22">|<img width="812" alt="image" src="https://github.com/user-attachments/assets/3ea854a3-f44e-4b76-ac9b-91862c0ae964">| ___________ ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 090d9a2)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 17, 2024
…of Tech. Preview badge (#193182) (#193213) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge (#193182)](#193182) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T17:56:05Z","message":"[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge (#193182)\n\n## Summary\r\n\r\nPR updates the Response Console and Isolate/Release flyouts with:\r\n\r\n- Removes the \"Technical Preview\" badge from the page/flyout title\r\n- Adds [EUI's Beta\r\nbadge](https://eui.elastic.co/#/display/badge#beta-badge-type) to the\r\nAgent Type Integration with labels of \"Technical Preview\"\r\n\r\n___________\r\n\r\n#### Response Console\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/838a7609-aaa2-439b-98d6-09cce2d1c4b4\">|<img\r\nwidth=\"835\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/948a0516-31dd-456b-8025-3a5a79dd7815\">|\r\n\r\n\r\n\r\n\r\n#### Isolate/Release Flyout\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"800\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/01767b5d-4e4c-403b-a31b-ae7c960a5288\">|<img\r\nwidth=\"799\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/577b0513-6a5d-486c-bcd3-38541022a818\">|\r\n\r\n\r\n\r\n#### Elastic Defend (no tech preview badge)\r\n\r\n\r\n|Responder|Isolation panel from alerts|\r\n|------|------|\r\n|<img width=\"757\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a5de5be5-2e04-4d8c-8c32-139b155fba22\">|<img\r\nwidth=\"812\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3ea854a3-f44e-4b76-ac9b-91862c0ae964\">|\r\n\r\n\r\n\r\n___________\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"090d9a2adf018a53fee56184a1788427e6054835","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","v8.15.2"],"title":"[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge","number":193182,"url":"https://github.com/elastic/kibana/pull/193182","mergeCommit":{"message":"[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge (#193182)\n\n## Summary\r\n\r\nPR updates the Response Console and Isolate/Release flyouts with:\r\n\r\n- Removes the \"Technical Preview\" badge from the page/flyout title\r\n- Adds [EUI's Beta\r\nbadge](https://eui.elastic.co/#/display/badge#beta-badge-type) to the\r\nAgent Type Integration with labels of \"Technical Preview\"\r\n\r\n___________\r\n\r\n#### Response Console\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/838a7609-aaa2-439b-98d6-09cce2d1c4b4\">|<img\r\nwidth=\"835\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/948a0516-31dd-456b-8025-3a5a79dd7815\">|\r\n\r\n\r\n\r\n\r\n#### Isolate/Release Flyout\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"800\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/01767b5d-4e4c-403b-a31b-ae7c960a5288\">|<img\r\nwidth=\"799\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/577b0513-6a5d-486c-bcd3-38541022a818\">|\r\n\r\n\r\n\r\n#### Elastic Defend (no tech preview badge)\r\n\r\n\r\n|Responder|Isolation panel from alerts|\r\n|------|------|\r\n|<img width=\"757\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a5de5be5-2e04-4d8c-8c32-139b155fba22\">|<img\r\nwidth=\"812\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3ea854a3-f44e-4b76-ac9b-91862c0ae964\">|\r\n\r\n\r\n\r\n___________\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"090d9a2adf018a53fee56184a1788427e6054835"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193182","number":193182,"mergeCommit":{"message":"[Security Solution][Endpoint] Updated Response Console display of Tech. Preview badge (#193182)\n\n## Summary\r\n\r\nPR updates the Response Console and Isolate/Release flyouts with:\r\n\r\n- Removes the \"Technical Preview\" badge from the page/flyout title\r\n- Adds [EUI's Beta\r\nbadge](https://eui.elastic.co/#/display/badge#beta-badge-type) to the\r\nAgent Type Integration with labels of \"Technical Preview\"\r\n\r\n___________\r\n\r\n#### Response Console\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/838a7609-aaa2-439b-98d6-09cce2d1c4b4\">|<img\r\nwidth=\"835\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/948a0516-31dd-456b-8025-3a5a79dd7815\">|\r\n\r\n\r\n\r\n\r\n#### Isolate/Release Flyout\r\n\r\n|Display|Hover on icon|\r\n|------|------|\r\n|<img width=\"800\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/01767b5d-4e4c-403b-a31b-ae7c960a5288\">|<img\r\nwidth=\"799\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/577b0513-6a5d-486c-bcd3-38541022a818\">|\r\n\r\n\r\n\r\n#### Elastic Defend (no tech preview badge)\r\n\r\n\r\n|Responder|Isolation panel from alerts|\r\n|------|------|\r\n|<img width=\"757\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a5de5be5-2e04-4d8c-8c32-139b155fba22\">|<img\r\nwidth=\"812\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3ea854a3-f44e-4b76-ac9b-91862c0ae964\">|\r\n\r\n\r\n\r\n___________\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"090d9a2adf018a53fee56184a1788427e6054835"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paul Tavares <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tomsonpl
pushed a commit
to tomsonpl/kibana
that referenced
this pull request
Sep 18, 2024
…h. Preview badge (elastic#193182) ## Summary PR updates the Response Console and Isolate/Release flyouts with: - Removes the "Technical Preview" badge from the page/flyout title - Adds [EUI's Beta badge](https://eui.elastic.co/#/display/badge#beta-badge-type) to the Agent Type Integration with labels of "Technical Preview" ___________ #### Response Console |Display|Hover on icon| |------|------| |<img width="716" alt="image" src="https://github.com/user-attachments/assets/838a7609-aaa2-439b-98d6-09cce2d1c4b4">|<img width="835" alt="image" src="https://github.com/user-attachments/assets/948a0516-31dd-456b-8025-3a5a79dd7815">| #### Isolate/Release Flyout |Display|Hover on icon| |------|------| |<img width="800" alt="image" src="https://github.com/user-attachments/assets/01767b5d-4e4c-403b-a31b-ae7c960a5288">|<img width="799" alt="image" src="https://github.com/user-attachments/assets/577b0513-6a5d-486c-bcd3-38541022a818">| #### Elastic Defend (no tech preview badge) |Responder|Isolation panel from alerts| |------|------| |<img width="757" alt="image" src="https://github.com/user-attachments/assets/a5de5be5-2e04-4d8c-8c32-139b155fba22">|<img width="812" alt="image" src="https://github.com/user-attachments/assets/3ea854a3-f44e-4b76-ac9b-91862c0ae964">| ___________ ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 090d9a2) # Conflicts: # x-pack/plugins/security_solution/public/flyout/document_details/isolate_host/header.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR updates the Response Console and Isolate/Release flyouts with:
Response Console
Isolate/Release Flyout
Elastic Defend (no tech preview badge)
Checklist