Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] Add actionable error message when generating logstash API keys (#192765) #192923

Closed
wants to merge 1 commit into from

Conversation

nchaulet
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nchaulet nchaulet enabled auto-merge (squash) September 13, 2024 19:29
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +790.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 169.8KB 170.1KB +345.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine referenced this pull request Sep 13, 2024
…PI keys (#192765) (#192929)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Add actionable error message when generating logstash API
keys (#192765)](#192765)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-13T12:03:31Z","message":"[Fleet]
Add actionable error message when generating logstash API keys
(#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet]
Add actionable error message when generating logstash API
keys","number":192765,"url":"https://github.com/elastic/kibana/pull/192765","mergeCommit":{"message":"[Fleet]
Add actionable error message when generating logstash API keys
(#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192765","number":192765,"mergeCommit":{"message":"[Fleet]
Add actionable error message when generating logstash API keys
(#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741"}},{"url":"https://github.com/elastic/kibana/pull/192923","number":192923,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
@nchaulet nchaulet closed this Sep 13, 2024
auto-merge was automatically disabled September 13, 2024 21:06

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants