[Fleet] Add actionable error message when generating logstash API keys #192765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kilfoyle
reviewed
Sep 12, 2024
...fleet/public/applications/fleet/sections/settings/components/logstash_instructions/hooks.tsx
Outdated
Show resolved
Hide resolved
kilfoyle
reviewed
Sep 12, 2024
...fleet/public/applications/fleet/sections/settings/components/logstash_instructions/hooks.tsx
Outdated
Show resolved
Hide resolved
kilfoyle
approved these changes
Sep 12, 2024
Co-authored-by: David Kilfoyle <[email protected]>
jen-huang
approved these changes
Sep 12, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
nchaulet
changed the title
kibanamachine
added
v9.0.0
backport:skip
nchaulet
added
v8.16.0
backport:version
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Sep 13, 2024
elastic#192765) (cherry picked from commit d07ba0f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added
backport:prev-major
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2024
elastic#192765) (cherry picked from commit d07ba0f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2024
elastic#192765) (cherry picked from commit d07ba0f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added
backport:skip
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2024
…PI keys (#192765) (#192929) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Add actionable error message when generating logstash API keys (#192765)](#192765) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-13T12:03:31Z","message":"[Fleet] Add actionable error message when generating logstash API keys (#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet] Add actionable error message when generating logstash API keys","number":192765,"url":"https://github.com/elastic/kibana/pull/192765","mergeCommit":{"message":"[Fleet] Add actionable error message when generating logstash API keys (#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192765","number":192765,"mergeCommit":{"message":"[Fleet] Add actionable error message when generating logstash API keys (#192765)","sha":"d07ba0fa49dbb07e831f0096f91ca56573713741"}},{"url":"https://github.com/elastic/kibana/pull/192923","number":192923,"branch":"8.x","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #190120
That PR add a better error message when generating an API key without logstash without the required permissions
UI Changes
@kilfoyle does the copy for that toast notification make sense to you
