Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.11.0 #192756

Merged
merged 18 commits into from
Sep 23, 2024
Merged

Upgrade EUI to v95.11.0 #192756

merged 18 commits into from
Sep 23, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Sep 12, 2024

v95.10.1v95.11.0

Note

The bulk of this release is EuiDataGrid. The component has been fully converted to Emotion, and several UX changes have been made to data cell actions. We recommend QA testing any data grid(s) that have custom styles applied to them.

Questions? Please see our Kibana upgrade FAQ.


v95.11.0

  • Updated EuiText, EuiTextColor, and EuiTextAlign with a new component prop that allows changing the default rendered <div> wrapper to a <span> or <p> tag. (#7993)
  • Updated EuiDataGrid's cell actions to always consistently be left-aligned, regardless of text content alignment (#8011)
  • Increased EuiDataGrid's cell actions hover zone to reduce UX friction when mousing over from the grid cell to its actions (#8011)

Bug fixes

  • Fixed EuiPopover to correctly inherit from EuiProvider's componentDefaults.EuiPortal.insert (#8003)
  • Fixed push EuiFlyoutResizables to not potentially block scrollbars on outside content (#8010)
  • Fixed an EuiDataGrid bug where the setCellProps callback passed by renderCellValue was not correctly applying custom data-test-subjs (#8011)

Accessibility

  • Updated the EuiBasicTable actions button's aria-label by adding a reference to the current row (#7994)

CSS-in-JS conversions

  • Converted EuiDataGrid's toolbar controls to Emotion (#7997)
    • Removed $euiDataGridPopoverMaxHeight
  • Converted EuiDataGrid to Emotion (#7998)
    • Removed $euiZDataGrid
    • Removed $euiZHeaderBelowDataGrid
  • Converted EuiDataGrid's gridStyles to Emotion; Removed the following Sass variables and mixins: (#8006)
    • $euiDataGridCellPaddingS
    • $euiDataGridCellPaddingM
    • $euiDataGridCellPaddingL
    • $euiDataGridVerticalBorder
    • $euiDataGridPrefix
    • $euiDataGridStyles
    • @euiDataGridSelector
    • @euiDataGridStyles
  • Converted EuiDataGrid's cell popover, actions, and focus outline to Emotion; Removed the following Sass variables and mixins: (#8011)
    • $euiZDataGridCellPopover
    • @euiDataGridCellFocus
  • Converted EuiDataGrid's row, header, and footer cells to Emotion; Removed the following Sass variables and mixins: (#8013)
    • $euiDataGridColumnResizerWidth
    • @euiDataGridRowCell
    • @euiDataGridHeaderCell
    • @euiDataGridFooterCell

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Sep 12, 2024
@cee-chen cee-chen force-pushed the eui/v95.11.0 branch 3 times, most recently from 7b4aaf3 to 6336a4d Compare September 16, 2024 23:02
- header control cells no longer have `.euiDataGridHeaderCell__content` wrappers
@cee-chen cee-chen force-pushed the eui/v95.11.0 branch 3 times, most recently from 8492a9b to 3d394c0 Compare September 17, 2024 21:38
- not totally sure how the Emotion conversion broke this :T but hovering over cells/etc helps ensure the button remains clickable
- `.euiDataGridHeader__action--selected` isn't a className that EUI sets anymore (as it wasn't doing anything) - we use sort/unsort copy

- Lens is overriding EUI's copy, so we need to update the tests to be more manual and remove the `none` option
- prefer className specific to column selector instead
- `.euiDataGridHeaderCell__button` now behaves very differently due to interactive children change, so center it instead of stretching it

- `.euiDataGridHeaderCell__popover` no longer exists

- `.euiDataGridRowCell__content` no longer exists for control columns

- `.euiDataGridRowCell--numeric` text alignment is already being applied by EUI, delete it
- `.euiDataGridHeaderCell__icon` no longer exists, use the data-test-subj attached directly to the column actions button instead

- `.euiDataGridHeaderCell__content` no longer exists in control columns

- `Unsort` text has been added to datagrid column actions to indicate a column is already being sorted
- row # has been added to each actions button
@cee-chen cee-chen marked this pull request as ready for review September 18, 2024 01:10
@cee-chen cee-chen requested review from a team as code owners September 18, 2024 01:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen requested review from a team as code owners September 18, 2024 01:10
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM. Tested locally (data grid usage in transforms and DFA).

Copy link

@l-suarez l-suarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the design point of view, all looks good.

I checked for visual regressions comparing current state and this pull request and didn't find differences. DataGrids checked in both light and dark theme:

  • Dashboards
  • Lens
  • Discover

Thank you!

PS - @elastic/kibana-design could you double check at your end? I'm not 100% familiar with the product yet and I might be missing something :S

…ntent div

I was derping and should not have removed the `__content` selector 🤦
@cee-chen cee-chen added the backport:version Backport to applied version labels label Sep 19, 2024
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM for the Threat Hunting Investigations team!

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM, thanks! 👍

Comment on lines -144 to -146
'shoes- a, column 1, row 1',
'1588024800000- b, column 2, row 1',
'3- c, column 3, row 1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this has changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The - a, column 1, row 1 is screen reader only text that I'm currently making several efforts to make less visible to users (e.g. in snapshots, during copy/paste events) while still remaining accessible to screen readers. This snapshot/test assertion change is a result of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up note: if you still wish to assert on cell col/row placement in EuiDataGrid, please use the data-gridcell-column-index and data-gridcell-visible-row-index attributes.

@@ -36,7 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await lens.getDatatableCellText(0, 0)).to.eql('169.228.188.120');
// Remove the sorting
await retry.try(async () => {
await lens.changeTableSortingBy(0, 'none');
await lens.changeTableSortingBy(0, 'descending');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the code underneath this change: apparently the new datagrid does mark any more the current sorting button as selected on the column actions dropdown.
So right now there's no way to get which "sorting" mode is currently "active" other than looking at the presence of the icon on the column.
Before a --selected class was added to the item.

Is this intentional?

Copy link
Contributor Author

@cee-chen cee-chen Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I removed .euiDataGridHeader__action--selected from our classNames/CSS as it wasn't actually applying any useful styles anymore, and I hadn't realized this FTR test was hooking into it 😬 I replaced it instead with logic that adds "Sort/Unsort" text to represent currently sorted state:

But it looks like the Lens datagrid completely overrides the sort label with your own Sort ascending/descending node, which means that the default "Unsort" text can't be hooked into.

Options I can look into:

  • Remove your label override with a schemaLabel instead, which means that you get EuiDataGrid's "Unsort" text (the schemaLabel replaces the A-Z/Z-A text only)
  • Re-add a selected state as a data- attribute of some kind that you can hook into (would likely be the next release, and I can revert the Lens changes at that point)

Copy link
Contributor

@dej611 dej611 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will convert this into a new follow up issue: #193826

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 20, 2024

I don't know for certain it was this PR that changed it, but the header is no longer fully clickable.
Perhaps that was intentional, so I am seeking clarification.

For comparison, on the oblt demo instance (8.16 snapshot), you can click anywhere in the column header to open the action menu (sort, etc.). In this PR, you now must click on the overflow menu button to open the menu. As I said, this may well have been intentional but want to double check the source/reason for the change.

Thanks!

This PR

8.16 snapshot

@cee-chen
Copy link
Contributor Author

@ryankeairns This change was not made in this EUI release or upgrade, it was made in #192026. Please see elastic/eui#7898, elastic/eui#7660, and elastic/eui#7469 for more context on the change and why several Kibana teams have requested it.

@ryankeairns ryankeairns requested a review from a team September 20, 2024 20:34
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional context!

@cee-chen cee-chen requested review from markov00 and dej611 September 23, 2024 19:06
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 23, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 7d15173
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192756-7d15173bc6bd

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 496.7KB 496.5KB -240.0B
discover 812.9KB 812.6KB -240.0B
esqlDataGrid 153.0KB 152.7KB -240.0B
securitySolution 20.4MB 20.4MB -1.2KB
slo 854.1KB 853.9KB -240.0B
unifiedDocViewer 122.1KB 122.1KB -16.0B
total -2.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 454.6KB 455.0KB +480.0B
kbnUiSharedDeps-css 148.7KB 129.6KB -19.1KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +23.8KB
total +5.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen
Copy link
Contributor Author

@dej611 @markov00 I'm moving forward with asking KibanaOps for an admin merge as we need to unblock EUI's release/upgrade process. @elastic/kibana-visualizations is the only CODEOWNER team remaining and your owned code only touches tests and no actual source code/user-impacting code, so I feel comfortable getting this into main for now. If you'd like me to follow up with another PR later, please feel free to ping me separately or over Slack. Thanks!

@Ikuni17 Ikuni17 merged commit 9bbb296 into elastic:main Sep 23, 2024
47 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
`v95.10.1`⏩`v95.11.0`

> [!note]
> The bulk of this release is **EuiDataGrid**. The component has been
fully converted to Emotion, and several UX changes have been made to
data cell actions. We recommend QA testing any data grid(s) that have
custom styles applied to them.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.11.0`](https://github.com/elastic/eui/releases/v95.11.0)

- Updated `EuiText`, `EuiTextColor`, and `EuiTextAlign` with a new
`component` prop that allows changing the default rendered `<div>`
wrapper to a `<span>` or `<p>` tag.
([elastic#7993](elastic/eui#7993))
- Updated `EuiDataGrid`'s cell actions to always consistently be
left-aligned, regardless of text content alignment
([elastic#8011](elastic/eui#8011))
- Increased `EuiDataGrid`'s cell actions hover zone to reduce UX
friction when mousing over from the grid cell to its actions
([elastic#8011](elastic/eui#8011))

**Bug fixes**

- Fixed `EuiPopover` to correctly inherit from `EuiProvider`'s
`componentDefaults.EuiPortal.insert`
([elastic#8003](elastic/eui#8003))
- Fixed push `EuiFlyoutResizable`s to not potentially block scrollbars
on outside content ([elastic#8010](elastic/eui#8010))
- Fixed an `EuiDataGrid` bug where the `setCellProps` callback passed by
`renderCellValue` was not correctly applying custom `data-test-subj`s
([elastic#8011](elastic/eui#8011))

**Accessibility**

- Updated the `EuiBasicTable` actions button's `aria-label` by adding a
reference to the current row
([elastic#7994](elastic/eui#7994))

**CSS-in-JS conversions**

- Converted `EuiDataGrid`'s toolbar controls to Emotion
([elastic#7997](elastic/eui#7997))
  - Removed `$euiDataGridPopoverMaxHeight`
- Converted `EuiDataGrid` to Emotion
([elastic#7998](elastic/eui#7998))
  - Removed `$euiZDataGrid`
  - Removed `$euiZHeaderBelowDataGrid`
- Converted `EuiDataGrid`'s `gridStyle`s to Emotion; Removed the
following Sass variables and mixins:
([elastic#8006](elastic/eui#8006))
  - `$euiDataGridCellPaddingS`
  - `$euiDataGridCellPaddingM`
  - `$euiDataGridCellPaddingL`
  - `$euiDataGridVerticalBorder`
  - `$euiDataGridPrefix`
  - `$euiDataGridStyles`
  - `@euiDataGridSelector`
  - `@euiDataGridStyles`
- Converted `EuiDataGrid`'s cell popover, actions, and focus outline to
Emotion; Removed the following Sass variables and mixins:
([elastic#8011](elastic/eui#8011))
  - `$euiZDataGridCellPopover`
  - `@euiDataGridCellFocus`
- Converted `EuiDataGrid`'s row, header, and footer cells to Emotion;
Removed the following Sass variables and mixins:
([elastic#8013](elastic/eui#8013))
  - `$euiDataGridColumnResizerWidth`
  - `@euiDataGridRowCell`
  - `@euiDataGridHeaderCell`
  - `@euiDataGridFooterCell`

(cherry picked from commit 9bbb296)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cee-chen cee-chen deleted the eui/v95.11.0 branch September 23, 2024 23:44
kibanamachine added a commit that referenced this pull request Sep 27, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Upgrade EUI to v95.11.0
(#192756)](#192756)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T22:45:19Z","message":"Upgrade
EUI to v95.11.0 (#192756)\n\n`v95.10.1`⏩`v95.11.0`\r\n\r\n> [!note]\r\n>
The bulk of this release is **EuiDataGrid**. The component has
been\r\nfully converted to Emotion, and several UX changes have been
made to\r\ndata cell actions. We recommend QA testing any data grid(s)
that have\r\ncustom styles applied to them.\r\n\r\n_[Questions? Please
see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v95.11.0`](https://github.com/elastic/eui/releases/v95.11.0)\r\n\r\n-
Updated `EuiText`, `EuiTextColor`, and `EuiTextAlign` with a
new\r\n`component` prop that allows changing the default rendered
`<div>`\r\nwrapper to a `<span>` or `<p>`
tag.\r\n([#7993](https://github.com/elastic/eui/pull/7993))\r\n- Updated
`EuiDataGrid`'s cell actions to always consistently be\r\nleft-aligned,
regardless of text content
alignment\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n-
Increased `EuiDataGrid`'s cell actions hover zone to reduce
UX\r\nfriction when mousing over from the grid cell to its
actions\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed `EuiPopover` to correctly inherit from
`EuiProvider`'s\r\n`componentDefaults.EuiPortal.insert`\r\n([#8003](https://github.com/elastic/eui/pull/8003))\r\n-
Fixed push `EuiFlyoutResizable`s to not potentially block
scrollbars\r\non outside content
([#8010](https://github.com/elastic/eui/pull/8010))\r\n- Fixed an
`EuiDataGrid` bug where the `setCellProps` callback passed
by\r\n`renderCellValue` was not correctly applying custom
`data-test-subj`s\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Accessibility**\r\n\r\n-
Updated the `EuiBasicTable` actions button's `aria-label` by adding
a\r\nreference to the current
row\r\n([#7994](https://github.com/elastic/eui/pull/7994))\r\n\r\n**CSS-in-JS
conversions**\r\n\r\n- Converted `EuiDataGrid`'s toolbar controls to
Emotion\r\n([#7997](https://github.com/elastic/eui/pull/7997))\r\n -
Removed `$euiDataGridPopoverMaxHeight`\r\n- Converted `EuiDataGrid` to
Emotion\r\n([#7998](https://github.com/elastic/eui/pull/7998))\r\n -
Removed `$euiZDataGrid`\r\n - Removed `$euiZHeaderBelowDataGrid`\r\n-
Converted `EuiDataGrid`'s `gridStyle`s to Emotion; Removed
the\r\nfollowing Sass variables and
mixins:\r\n([#8006](https://github.com/elastic/eui/pull/8006))\r\n -
`$euiDataGridCellPaddingS`\r\n - `$euiDataGridCellPaddingM`\r\n -
`$euiDataGridCellPaddingL`\r\n - `$euiDataGridVerticalBorder`\r\n -
`$euiDataGridPrefix`\r\n - `$euiDataGridStyles`\r\n -
`@euiDataGridSelector`\r\n - `@euiDataGridStyles`\r\n- Converted
`EuiDataGrid`'s cell popover, actions, and focus outline to\r\nEmotion;
Removed the following Sass variables and
mixins:\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n -
`$euiZDataGridCellPopover`\r\n - `@euiDataGridCellFocus`\r\n- Converted
`EuiDataGrid`'s row, header, and footer cells to Emotion;\r\nRemoved the
following Sass variables and
mixins:\r\n([#8013](https://github.com/elastic/eui/pull/8013))\r\n -
`$euiDataGridColumnResizerWidth`\r\n - `@euiDataGridRowCell`\r\n -
`@euiDataGridHeaderCell`\r\n -
`@euiDataGridFooterCell`","sha":"9bbb296078ea385561d46819001644cdb4fdc714","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"Upgrade
EUI to
v95.11.0","number":192756,"url":"https://github.com/elastic/kibana/pull/192756","mergeCommit":{"message":"Upgrade
EUI to v95.11.0 (#192756)\n\n`v95.10.1`⏩`v95.11.0`\r\n\r\n> [!note]\r\n>
The bulk of this release is **EuiDataGrid**. The component has
been\r\nfully converted to Emotion, and several UX changes have been
made to\r\ndata cell actions. We recommend QA testing any data grid(s)
that have\r\ncustom styles applied to them.\r\n\r\n_[Questions? Please
see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v95.11.0`](https://github.com/elastic/eui/releases/v95.11.0)\r\n\r\n-
Updated `EuiText`, `EuiTextColor`, and `EuiTextAlign` with a
new\r\n`component` prop that allows changing the default rendered
`<div>`\r\nwrapper to a `<span>` or `<p>`
tag.\r\n([#7993](https://github.com/elastic/eui/pull/7993))\r\n- Updated
`EuiDataGrid`'s cell actions to always consistently be\r\nleft-aligned,
regardless of text content
alignment\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n-
Increased `EuiDataGrid`'s cell actions hover zone to reduce
UX\r\nfriction when mousing over from the grid cell to its
actions\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed `EuiPopover` to correctly inherit from
`EuiProvider`'s\r\n`componentDefaults.EuiPortal.insert`\r\n([#8003](https://github.com/elastic/eui/pull/8003))\r\n-
Fixed push `EuiFlyoutResizable`s to not potentially block
scrollbars\r\non outside content
([#8010](https://github.com/elastic/eui/pull/8010))\r\n- Fixed an
`EuiDataGrid` bug where the `setCellProps` callback passed
by\r\n`renderCellValue` was not correctly applying custom
`data-test-subj`s\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Accessibility**\r\n\r\n-
Updated the `EuiBasicTable` actions button's `aria-label` by adding
a\r\nreference to the current
row\r\n([#7994](https://github.com/elastic/eui/pull/7994))\r\n\r\n**CSS-in-JS
conversions**\r\n\r\n- Converted `EuiDataGrid`'s toolbar controls to
Emotion\r\n([#7997](https://github.com/elastic/eui/pull/7997))\r\n -
Removed `$euiDataGridPopoverMaxHeight`\r\n- Converted `EuiDataGrid` to
Emotion\r\n([#7998](https://github.com/elastic/eui/pull/7998))\r\n -
Removed `$euiZDataGrid`\r\n - Removed `$euiZHeaderBelowDataGrid`\r\n-
Converted `EuiDataGrid`'s `gridStyle`s to Emotion; Removed
the\r\nfollowing Sass variables and
mixins:\r\n([#8006](https://github.com/elastic/eui/pull/8006))\r\n -
`$euiDataGridCellPaddingS`\r\n - `$euiDataGridCellPaddingM`\r\n -
`$euiDataGridCellPaddingL`\r\n - `$euiDataGridVerticalBorder`\r\n -
`$euiDataGridPrefix`\r\n - `$euiDataGridStyles`\r\n -
`@euiDataGridSelector`\r\n - `@euiDataGridStyles`\r\n- Converted
`EuiDataGrid`'s cell popover, actions, and focus outline to\r\nEmotion;
Removed the following Sass variables and
mixins:\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n -
`$euiZDataGridCellPopover`\r\n - `@euiDataGridCellFocus`\r\n- Converted
`EuiDataGrid`'s row, header, and footer cells to Emotion;\r\nRemoved the
following Sass variables and
mixins:\r\n([#8013](https://github.com/elastic/eui/pull/8013))\r\n -
`$euiDataGridColumnResizerWidth`\r\n - `@euiDataGridRowCell`\r\n -
`@euiDataGridHeaderCell`\r\n -
`@euiDataGridFooterCell`","sha":"9bbb296078ea385561d46819001644cdb4fdc714"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192756","number":192756,"mergeCommit":{"message":"Upgrade
EUI to v95.11.0 (#192756)\n\n`v95.10.1`⏩`v95.11.0`\r\n\r\n> [!note]\r\n>
The bulk of this release is **EuiDataGrid**. The component has
been\r\nfully converted to Emotion, and several UX changes have been
made to\r\ndata cell actions. We recommend QA testing any data grid(s)
that have\r\ncustom styles applied to them.\r\n\r\n_[Questions? Please
see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v95.11.0`](https://github.com/elastic/eui/releases/v95.11.0)\r\n\r\n-
Updated `EuiText`, `EuiTextColor`, and `EuiTextAlign` with a
new\r\n`component` prop that allows changing the default rendered
`<div>`\r\nwrapper to a `<span>` or `<p>`
tag.\r\n([#7993](https://github.com/elastic/eui/pull/7993))\r\n- Updated
`EuiDataGrid`'s cell actions to always consistently be\r\nleft-aligned,
regardless of text content
alignment\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n-
Increased `EuiDataGrid`'s cell actions hover zone to reduce
UX\r\nfriction when mousing over from the grid cell to its
actions\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed `EuiPopover` to correctly inherit from
`EuiProvider`'s\r\n`componentDefaults.EuiPortal.insert`\r\n([#8003](https://github.com/elastic/eui/pull/8003))\r\n-
Fixed push `EuiFlyoutResizable`s to not potentially block
scrollbars\r\non outside content
([#8010](https://github.com/elastic/eui/pull/8010))\r\n- Fixed an
`EuiDataGrid` bug where the `setCellProps` callback passed
by\r\n`renderCellValue` was not correctly applying custom
`data-test-subj`s\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n\r\n**Accessibility**\r\n\r\n-
Updated the `EuiBasicTable` actions button's `aria-label` by adding
a\r\nreference to the current
row\r\n([#7994](https://github.com/elastic/eui/pull/7994))\r\n\r\n**CSS-in-JS
conversions**\r\n\r\n- Converted `EuiDataGrid`'s toolbar controls to
Emotion\r\n([#7997](https://github.com/elastic/eui/pull/7997))\r\n -
Removed `$euiDataGridPopoverMaxHeight`\r\n- Converted `EuiDataGrid` to
Emotion\r\n([#7998](https://github.com/elastic/eui/pull/7998))\r\n -
Removed `$euiZDataGrid`\r\n - Removed `$euiZHeaderBelowDataGrid`\r\n-
Converted `EuiDataGrid`'s `gridStyle`s to Emotion; Removed
the\r\nfollowing Sass variables and
mixins:\r\n([#8006](https://github.com/elastic/eui/pull/8006))\r\n -
`$euiDataGridCellPaddingS`\r\n - `$euiDataGridCellPaddingM`\r\n -
`$euiDataGridCellPaddingL`\r\n - `$euiDataGridVerticalBorder`\r\n -
`$euiDataGridPrefix`\r\n - `$euiDataGridStyles`\r\n -
`@euiDataGridSelector`\r\n - `@euiDataGridStyles`\r\n- Converted
`EuiDataGrid`'s cell popover, actions, and focus outline to\r\nEmotion;
Removed the following Sass variables and
mixins:\r\n([#8011](https://github.com/elastic/eui/pull/8011))\r\n -
`$euiZDataGridCellPopover`\r\n - `@euiDataGridCellFocus`\r\n- Converted
`EuiDataGrid`'s row, header, and footer cells to Emotion;\r\nRemoved the
following Sass variables and
mixins:\r\n([#8013](https://github.com/elastic/eui/pull/8013))\r\n -
`$euiDataGridColumnResizerWidth`\r\n - `@euiDataGridRowCell`\r\n -
`@euiDataGridHeaderCell`\r\n -
`@euiDataGridFooterCell`","sha":"9bbb296078ea385561d46819001644cdb4fdc714"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Cee Chen <[email protected]>
Co-authored-by: Cee Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Accessibility) top right "Filter out" hover menu in result list conflicts with browser scroll bar