Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsconfig): uncomment option moduleDetection #191834

Merged
merged 7 commits into from
Sep 19, 2024
+7 −63
Merged

chore(tsconfig): uncomment option moduleDetection #191834

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1dee89f
chore(tsconfig): uncomment option `moduleDetection`
afharo Aug 30, 2024
a05555e
Fix format via `yarn kbn bootstrap`
afharo Aug 30, 2024
665158d
Address all TODOs from #144841
afharo Aug 30, 2024
9b688cb
Merge branch 'main' into module-detection-force
afharo Sep 17, 2024
22f1525
Merge branch 'main' of github.com:elastic/kibana into module-detectio…
afharo Sep 18, 2024
4d45e8b
Merge branch 'main' into module-detection-force
afharo Sep 19, 2024
cef21a1
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,11 +1974,8 @@
"useUnknownInCatchVariables": false,
// enabled to point out not supported features when emitting in an isolated module environment
"isolatedModules": true,
// TODO(jbudz): should be uncommented when upgrading to [email protected]
//
// ensures every non-declaration file is treated as a module
// "moduleDetection": "force",
//
"moduleDetection": "force",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few seemingly related todo comments introduced in the original PR. Maybe they can be removed too?

#144841

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Done in 665158d (#191834)

// disabled for better IDE support, enabled when running the type_check script
"composite": false,
// enabled for improved performance
Expand Down