Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tsconfig): uncomment option moduleDetection #191834

Merged
merged 7 commits into from
Sep 19, 2024
Merged

chore(tsconfig): uncomment option moduleDetection #191834

merged 7 commits into from
Sep 19, 2024
+7 −63

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 30, 2024 •
edited by kibanamachine
Loading

Summary

Just applying a TODO we had past its due dependency.
cc @mistic

For maintainers

@afharo afharo added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@afharo afharo requested a review from a team August 30, 2024 13:29
jbudz
jbudz reviewed Aug 30, 2024
View reviewed changes
tsconfig.base.json
// ensures every non-declaration file is treated as a module
// "moduleDetection": "force",
//
"moduleDetection": "force",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few seemingly related todo comments introduced in the original PR. Maybe they can be removed too?

#144841

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Done in 665158d (#191834)

@afharo afharo requested review from a team as code owners August 30, 2024 16:28
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nreese
nreese approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

paul-tavares
paul-tavares approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from elastic/security-defend-workflows team standpoint

@afharo
Copy link
Member Author

afharo commented Sep 18, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@afharo afharo enabled auto-merge (squash) September 19, 2024 10:31
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner September 19, 2024 11:21
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 3.7KB 3.7KB -21.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 119 118 -1

Total ESLint disabled count

id before after diff
osquery 119 118 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Sep 19, 2024
@afharo afharo merged commit f8ad0f1 into elastic:main Sep 19, 2024
66 of 68 checks passed
@afharo afharo deleted the module-detection-force branch September 19, 2024 20:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
@afharo
chore(tsconfig): uncomment option moduleDetection (elastic#191834)
01f25a3 
(cherry picked from commit f8ad0f1)
@kibanamachine kibanamachine mentioned this pull request Sep 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 20, 2024
@kibanamachine @afharo
[8.x] chore(tsconfig): uncomment option `moduleDetection` (#…
78e9b76 
…191834) (#193481)

# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(tsconfig): uncomment option `moduleDetection`
(#191834)](#191834)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T20:04:14Z","message":"chore(tsconfig):
uncomment option `moduleDetection`
(#191834)","sha":"f8ad0f1ec920600de6ede16e54c2e2aafbe5ce57","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","Feature:Drilldowns","Team:Fleet","v9.0.0","Team:Search","backport:prev-minor"],"title":"chore(tsconfig):
uncomment option
`moduleDetection`","number":191834,"url":"https://github.com/elastic/kibana/pull/191834","mergeCommit":{"message":"chore(tsconfig):
uncomment option `moduleDetection`
(#191834)","sha":"f8ad0f1ec920600de6ede16e54c2e2aafbe5ce57"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191834","number":191834,"mergeCommit":{"message":"chore(tsconfig):
uncomment option `moduleDetection`
(#191834)","sha":"f8ad0f1ec920600de6ede16e54c2e2aafbe5ce57"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliidm vitaliidm vitaliidm approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@jillguyonnet jillguyonnet jillguyonnet approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@jbudz jbudz jbudz approved these changes

@adcoelho adcoelho adcoelho approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@dej611 dej611 dej611 approved these changes

@nreese nreese nreese approved these changes

@joemcelroy joemcelroy joemcelroy approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) chore Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team Team:Search v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.