[ML][Fleet] Link to ML assets from Integration > Assets tab #189767

alvarezmelissa87 · 2024-08-01T23:18:59Z

Summary

Related issue: #182199

This PR adds links for ML assets installed via Integrations.

For transform and ml_model (as they are ES asset types) the manual mappings in get_bulk_assets.ts has been modified to include a link to the Transform management page and the Trained models page, respectively. The pages will be filtered to the asset id.

This PR also adds the ability to save state in the url for the Transform list to allow the url to link to a filtered list of transforms.

To test:

From the side navigation - click the Add integrations button at the bottom to get to the Integrations page.

To test ml models link, install the Living off the Land Attack Detection integration
To test transform link, install the Lateral Movement Detection integration
Once they are installed you can navigate to the Installed Integrations tab on the Integrations page

Select the installed package you want to view and then go to the Assets tab

You can then expand the desired asset section (Ml models or transforms) and click the link to ensure it takes you to the correct place

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

peteharverson · 2024-08-02T15:14:53Z

...nsform/public/app/sections/transform_management/components/transform_list/transform_list.tsx

    box: {
      incremental: true,
    },
    filters: transformFilters,
+    query: query?.queryText,


Not sure if it's related to any changes here, but the filter buttons for status and health aren't working for me. Whatever I select, I get no matches. Only 'mode' works as expected.

Fixed in dd8e5b7

peteharverson · 2024-08-02T15:57:51Z

x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts

@@ -33,11 +33,9 @@ const getKibanaLinkForESAsset = (type: ElasticsearchAssetType, id: string): stri
    case 'data_stream_ilm_policy':
      return `/app/management/data/index_lifecycle_management/policies/edit/${id}`;
    case 'transform':
-      // TODO: Confirm link for transforms
-      return '';
+      return `/app/management/data/transform?_a=(transform:(queryText:${id}))`;


Might not be possible, but adding the description of the transform, if set, would be nice here, as happens for dashboard assets:

Currently for ES assets that isn't possible but I can create a follow up issue to allow it for ES assets.

peteharverson · 2024-08-02T15:58:19Z

x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts

    case 'ml_model':
-      // TODO: Confirm link for ml models
-      return '';
+      return `/app/ml/trained_models?_a=(trained_models:(queryText:'model_id:(${id})'))`;


Same for models - would be nice to add the description, if it exists.

❓ is it possible to utilize our ML locator to retrieve these URLs? It'd make it easier to maintain

I was directed to keep it consistent in that file, for now. If maintainability becomes an issue then we can bring it up.

elasticmachine · 2024-08-05T18:41:25Z

Pinging @elastic/ml-ui (:ml)

elasticmachine · 2024-08-05T20:08:14Z

Pinging @elastic/fleet (Team:Fleet)

jen-huang

Fleet changes LGTM. Thanks!

walterra

LGTM, tested url state and the links from integration packages!

darnautov · 2024-08-12T09:45:13Z

@elasticmachine merge upstream

darnautov · 2024-08-12T09:47:55Z

x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts

    case 'ml_model':
-      // TODO: Confirm link for ml models
-      return '';
+      return `/app/ml/trained_models?_a=(trained_models:(queryText:'model_id:(${id})'))`;


❓ is it possible to utilize our ML locator to retrieve these URLs? It'd make it easier to maintain

.../plugins/transform/public/app/sections/transform_management/transform_management_section.tsx

darnautov · 2024-08-12T10:02:42Z

...orm/public/app/sections/transform_management/components/transform_list/use_table_settings.ts

+  const onTableChange: EuiBasicTableProps<TypeOfItem>['onChange'] = useCallback(
+    ({ page, sort }: CriteriaWithPagination<TypeOfItem>) => {
+      let resultSortField = sort?.field;
+      if (typeof resultSortField !== 'string') {


what other types can it be?

🤔 I think this is holdover defensive code from the example code I was using from https://github.com/elastic/kibana/pull/140613/files in use_table_settings.ts
I think it depends on the dataset - it's possible it could not be a string type always.

kibana-ci · 2024-08-12T19:59:55Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 3e81b35

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ml-url-state`	24	35	+11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	632.6KB	634.4KB	+1.7KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/ml-url-state`	31	42	+11

History

💚 Build #227014 succeeded ca89c98
💚 Build #226683 succeeded c024c1d
💔 Build #226368 failed 791863a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

…189767) ## Summary Related issue: elastic#182199 This PR adds links for ML assets installed via Integrations. For `transform` and `ml_model` (as they are ES asset types) the manual mappings in [get_bulk_assets.ts](https://github.com/elastic/kibana/blob/ac6f643904c6bb7e8342b68e470e933e33a7c206/x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts#L21) has been modified to include a link to the Transform management page and the Trained models page, respectively. The pages will be filtered to the asset id. This PR also adds the ability to save state in the url for the Transform list to allow the url to link to a filtered list of transforms. ### To test: - From the side navigation - click the `Add integrations` button at the bottom to get to the Integrations page. <img width="318" alt="image" src="https://github.com/user-attachments/assets/d4632221-7f83-4678-ac0f-cb1e20853a6d"> - To test ml models link, install the `Living off the Land Attack Detection` integration - To test transform link, install the `Lateral Movement Detection` integration - Once they are installed you can navigate to the `Installed Integrations` tab on the Integrations page <img width="660" alt="image" src="https://github.com/user-attachments/assets/8dc1db76-4b93-4057-b502-a90980a2a484"> - Select the installed package you want to view and then go to the `Assets` tab <img width="1256" alt="image" src="https://github.com/user-attachments/assets/c3382f9d-b1ed-4043-ac3f-73180effefe8"> - You can then expand the desired asset section (Ml models or transforms) and click the link to ensure it takes you to the correct place ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Elastic Machine <[email protected]>

add links for transform and model integration assets

796a79d

alvarezmelissa87 added release_note:enhancement :ml v8.16.0 labels Aug 1, 2024

alvarezmelissa87 self-assigned this Aug 1, 2024

peteharverson reviewed Aug 2, 2024

View reviewed changes

alvarezmelissa87 requested review from walterra and jgowdyelastic August 2, 2024 20:10

alvarezmelissa87 added 4 commits August 2, 2024 15:19

ensure searchbar filter finds stats.status

454e274

catch search query errors

9c7e66a

Merge branch 'main' into ml-integration-assets-links

70338f4

fix health filter for transforms

dd8e5b7

alvarezmelissa87 marked this pull request as ready for review August 5, 2024 18:41

alvarezmelissa87 requested review from a team as code owners August 5, 2024 18:41

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 5, 2024

jen-huang approved these changes Aug 5, 2024

View reviewed changes

alvarezmelissa87 requested a review from darnautov August 6, 2024 16:55

alvarezmelissa87 added 2 commits August 7, 2024 11:36

Merge branch 'main' into ml-integration-assets-links

791863a

update tests

c024c1d

walterra approved these changes Aug 9, 2024

View reviewed changes

Merge branch 'main' into ml-integration-assets-links

ca89c98

darnautov reviewed Aug 12, 2024

View reviewed changes

dedup types

3e81b35

darnautov approved these changes Aug 13, 2024

View reviewed changes

alvarezmelissa87 merged commit 8be5ad8 into elastic:main Aug 13, 2024
23 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Aug 13, 2024

alvarezmelissa87 deleted the ml-integration-assets-links branch August 13, 2024 14:55

alvarezmelissa87 mentioned this pull request Aug 13, 2024

[ML][Fleet] Link to ML assets from Integration > Assets tab #182199

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML][Fleet] Link to ML assets from Integration > Assets tab #189767

[ML][Fleet] Link to ML assets from Integration > Assets tab #189767

alvarezmelissa87 commented Aug 1, 2024 •

edited

Loading

peteharverson Aug 2, 2024

alvarezmelissa87 Aug 5, 2024

peteharverson Aug 2, 2024

alvarezmelissa87 Aug 5, 2024

peteharverson Aug 2, 2024

darnautov Aug 12, 2024

alvarezmelissa87 Aug 12, 2024

elasticmachine commented Aug 5, 2024

elasticmachine commented Aug 5, 2024

jen-huang left a comment

walterra left a comment

darnautov commented Aug 12, 2024

darnautov Aug 12, 2024

darnautov Aug 12, 2024

alvarezmelissa87 Aug 12, 2024

kibana-ci commented Aug 12, 2024

API count

[ML][Fleet] Link to ML assets from Integration > Assets tab #189767

[ML][Fleet] Link to ML assets from Integration > Assets tab #189767

Conversation

alvarezmelissa87 commented Aug 1, 2024 • edited Loading

Summary

To test:

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Aug 5, 2024

elasticmachine commented Aug 5, 2024

jen-huang left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

darnautov commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Aug 12, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

alvarezmelissa87 commented Aug 1, 2024 •

edited

Loading