Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Fleet] Link to ML assets from Integration > Assets tab #182199

Closed
3 tasks done
jen-huang opened this issue Apr 30, 2024 · 3 comments
Closed
3 tasks done

[ML][Fleet] Link to ML assets from Integration > Assets tab #182199

jen-huang opened this issue Apr 30, 2024 · 3 comments
Assignees
Labels
enhancement New value added to drive a business result :ml Team:ML Team label for ML (also use :ml) v8.16.0

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Apr 30, 2024

With the work in #182180, Integration > Assets tab now lists all assets tracked on the package installation saved object after the package is installed (installed_es and installed_kibana) and attempts to link them to other apps in Kibana for viewing.

The following ML assets types are currently unlinked:

As part of this issue, please:

  • Decide if and where each asset type should link to
  • Update the Fleet code with the links
    • For Kibana asset types, we recommend to add a management.getInAppUrl() function to the saved object registration. No further changes are necessary in Fleet if this is done. Here is an example of this kind of registration.
    • For ES asset types, modify the manual mappings in get_bulk_assets.ts

If an asset type should not even be displayed on this page, please:

@jen-huang jen-huang added enhancement New value added to drive a business result Team:ML Team label for ML (also use :ml) labels Apr 30, 2024
jen-huang added a commit that referenced this issue May 1, 2024
## Summary
Resolves #160555.

This PR allows all assets to be shown on Integration details > Assets
tab and links them to other apps in Kibana whenever possible for
viewing. Previously, only dashboards, visualizations, and saved searches
were shown in this view. Now all Kibana and Elasticsearch assets are
shown if the integration was installed in the user's current space.

If an integration was installed in a different space, only ES assets
will be shown.

#### Caveats
1) This page lists all assets tracked on the package installation saved
object *after* the package is installed (`installed_es` and
`installed_kibana`). This list differs from the summary of assets shown
on the Overview tab because it includes Fleet-installed assets that are
not part of the package, notably index templates, component templates,
and default ingest pipelines.
#182197 was created to decide
how to resolve this asset count discrepency.

2) ML and Security assets are shown but not linked. The following issues
have been created for downstream teams to decide where their assets
should link to: #182199, #182200

### Screenshots
<details>
<summary>Nginx (including in a different space)</summary>


![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8)


![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635)
</details>

<details>
<summary>Security Posture Management</summary>


![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f)
</details>

<details>
<summary>Rapid7 Threat Command</summary>


![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba)
</details>

<details>
<summary>Lateral Movement Detection</summary>


![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7)
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
@jen-huang
Copy link
Contributor Author

cc @elastic/ml-ui to get this on your radar. I wasn't sure of the team label/ping to use.

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Jul 26, 2024

  • Transforms should link to the transforms page (pass in link to filter for that one transform)
  • Models should link to models list

Could also be useful to have a way for the user to view the contents of the ml_modules part - maybe they can view the job configs?
Currently they have to go through the wizard to see these.

alvarezmelissa87 added a commit that referenced this issue Aug 13, 2024
## Summary

Related issue: #182199

This PR adds links for ML assets installed via Integrations. 

For `transform` and `ml_model` (as they are ES asset types) the manual
mappings in
[get_bulk_assets.ts](https://github.com/elastic/kibana/blob/ac6f643904c6bb7e8342b68e470e933e33a7c206/x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts#L21)
has been modified to include a link to the Transform management page and
the Trained models page, respectively. The pages will be filtered to the
asset id.

This PR also adds the ability to save state in the url for the Transform
list to allow the url to link to a filtered list of transforms.

### To test:

- From the side navigation - click the `Add integrations` button at the
bottom to get to the Integrations page.
<img width="318" alt="image"
src="https://github.com/user-attachments/assets/d4632221-7f83-4678-ac0f-cb1e20853a6d">

- To test ml models link, install the `Living off the Land Attack
Detection` integration
- To test transform link, install the `Lateral Movement Detection`
integration

- Once they are installed you can navigate to the `Installed
Integrations` tab on the Integrations page
<img width="660" alt="image"
src="https://github.com/user-attachments/assets/8dc1db76-4b93-4057-b502-a90980a2a484">

- Select the installed package you want to view and then go to the
`Assets` tab
<img width="1256" alt="image"
src="https://github.com/user-attachments/assets/c3382f9d-b1ed-4043-ac3f-73180effefe8">

- You can then expand the desired asset section (Ml models or
transforms) and click the link to ensure it takes you to the correct
place


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Elastic Machine <[email protected]>
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 13, 2024
…189767)

## Summary

Related issue: elastic#182199

This PR adds links for ML assets installed via Integrations. 

For `transform` and `ml_model` (as they are ES asset types) the manual
mappings in
[get_bulk_assets.ts](https://github.com/elastic/kibana/blob/ac6f643904c6bb7e8342b68e470e933e33a7c206/x-pack/plugins/fleet/server/services/epm/packages/get_bulk_assets.ts#L21)
has been modified to include a link to the Transform management page and
the Trained models page, respectively. The pages will be filtered to the
asset id.

This PR also adds the ability to save state in the url for the Transform
list to allow the url to link to a filtered list of transforms.

### To test:

- From the side navigation - click the `Add integrations` button at the
bottom to get to the Integrations page.
<img width="318" alt="image"
src="https://github.com/user-attachments/assets/d4632221-7f83-4678-ac0f-cb1e20853a6d">

- To test ml models link, install the `Living off the Land Attack
Detection` integration
- To test transform link, install the `Lateral Movement Detection`
integration

- Once they are installed you can navigate to the `Installed
Integrations` tab on the Integrations page
<img width="660" alt="image"
src="https://github.com/user-attachments/assets/8dc1db76-4b93-4057-b502-a90980a2a484">

- Select the installed package you want to view and then go to the
`Assets` tab
<img width="1256" alt="image"
src="https://github.com/user-attachments/assets/c3382f9d-b1ed-4043-ac3f-73180effefe8">

- You can then expand the desired asset section (Ml models or
transforms) and click the link to ensure it takes you to the correct
place


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Elastic Machine <[email protected]>
alvarezmelissa87 added a commit that referenced this issue Sep 19, 2024
…ation > Assets tab (#193105)

## Summary

Related issue: #182199

This PR adds a link to `ML > Anomaly Detection > Supplied
Configurations` from `Integration > Assets tab` for 'ML Modules' assets.

The naming of the asset is also updated in Fleet to be consistent with
the ML UI.

<img width="429" alt="Screenshot 2024-09-19 at 13 46 47"
src="https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57">

<img width="717" alt="Screenshot 2024-09-19 at 13 47 52"
src="https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 19, 2024
…ation > Assets tab (elastic#193105)

## Summary

Related issue: elastic#182199

This PR adds a link to `ML > Anomaly Detection > Supplied
Configurations` from `Integration > Assets tab` for 'ML Modules' assets.

The naming of the asset is also updated in Fleet to be consistent with
the ML UI.

<img width="429" alt="Screenshot 2024-09-19 at 13 46 47"
src="https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57">

<img width="717" alt="Screenshot 2024-09-19 at 13 47 52"
src="https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a">

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 052187c)
kibanamachine added a commit that referenced this issue Sep 19, 2024
…Integration &gt; Assets tab (#193105) (#193485)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML][Fleet] Adds link to anomaly detection configurations from
Integration &gt; Assets tab
(#193105)](#193105)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T20:40:44Z","message":"[ML][Fleet]
Adds link to anomaly detection configurations from Integration > Assets
tab (#193105)\n\n## Summary\r\n\r\nRelated issue:
#182199 PR
adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations`
from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe
naming of the asset is also updated in Fleet to be consistent
with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19
at 13 46
47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img
width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47
52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"052187ce180f0cbcb062486f36a562495f840bef","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ML][Fleet]
Adds link to anomaly detection configurations from Integration > Assets
tab","number":193105,"url":"https://github.com/elastic/kibana/pull/193105","mergeCommit":{"message":"[ML][Fleet]
Adds link to anomaly detection configurations from Integration > Assets
tab (#193105)\n\n## Summary\r\n\r\nRelated issue:
#182199 PR
adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations`
from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe
naming of the asset is also updated in Fleet to be consistent
with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19
at 13 46
47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img
width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47
52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"052187ce180f0cbcb062486f36a562495f840bef"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193105","number":193105,"mergeCommit":{"message":"[ML][Fleet]
Adds link to anomaly detection configurations from Integration > Assets
tab (#193105)\n\n## Summary\r\n\r\nRelated issue:
#182199 PR
adds a link to `ML > Anomaly Detection > Supplied\r\nConfigurations`
from `Integration > Assets tab` for 'ML Modules' assets.\r\n\r\nThe
naming of the asset is also updated in Fleet to be consistent
with\r\nthe ML UI.\r\n\r\n<img width=\"429\" alt=\"Screenshot 2024-09-19
at 13 46
47\"\r\nsrc=\"https://github.com/user-attachments/assets/9fcc3606-cc08-483f-88b4-00c07de3fc57\">\r\n\r\n<img
width=\"717\" alt=\"Screenshot 2024-09-19 at 13 47
52\"\r\nsrc=\"https://github.com/user-attachments/assets/847f3d6e-95a1-491c-aa3e-7d54da7df98a\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"052187ce180f0cbcb062486f36a562495f840bef"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
@alvarezmelissa87
Copy link
Contributor

Closing as all items are completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result :ml Team:ML Team label for ML (also use :ml) v8.16.0
Projects
None yet
Development

No branches or pull requests

3 participants