[Fleet] add setup technology selector to add integration page #189612

juliaElastic · 2024-07-31T09:54:17Z

Summary

TODO refactor cspm integration so that the same setup technology selector is used as other packages
I might do this in a separate pr, it seems this pr also adds Beta badge to the cspm selector #189217

Note: in Serverless, currently the preconfigured agentless agent policy is being used for all agentless integrations. When Agentless API is supported in serverless, this code can be removed and serverless will work the same way as ESS. Related issue https://github.com/elastic/security-team/issues/9781

Open question:

Do we want to allow preconfigured agentless agent policies in ESS? Currently it's only allowed in serverless: https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/services/preconfiguration.ts#L167-L176

Requirements completed:

Add a agentless/agent-based selector component when deployment_modes.agentless.enabled: true is set on a given policy template
Hide/show the "Select or create agent policy" UI based on the state of the agentless selector
Always create a new agent policy when saving an integration policy in agentless mode. This newly created policy should have supports_agentless: true set.
When deleting an agentless integration policy, the agentless agent policy should also be deleted
The toggle and agentless logic should still be gated behind the agentless feature flag in addition to the integration level configuration
Ensure that even if supports_agentless: true is set, the policy editor default to the current agent-based option and the toggle is set to agent-based
Ensure that the agentless option is clearly marked as beta, and display a beta banner in the policy editor form itself to reiterate this when agentless mode is enabled
Editing an agentless integration policy should not be possible. The "edit" action should be disabled with a tooltip directing the user to instead create a new integration policy and delete the existing one.

Steps to verify locally (ESS):

Add to kibana.dev.yml:

xpack.fleet.enableExperimental: ['agentless'] 
xpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess'
xpack.fleet.agentless.api.tls.certificate: './config/node.crt'
xpack.fleet.agentless.api.tls.key: './config/node.key'
xpack.fleet.agentless.api.tls.ca: './config/ca.crt'
xpack.cloud.id: '123456789'

Upload agentless package agentless_test_package-0.0.1.zip

curl -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' http://localhost:5601/julia/api/fleet/epm/packages -u elastic:changeme --data-binary @agentless_test_package-0.0.1.zip

Verify Agent-based option:

Go to Add integration - Agentless test package
Setup technology selector should be visible, Agent-based option selected by default
New/Existing agent policy selection should be visible
On submitting, the Agentless test package integration policy should be created with the selected agent policies as normal
Edit integration should be enabled as normal

Verify Agentless option:

To verify the agentless option, add another integration
Select Agentless option in the selector
New/Existing agent policy selection should be hidden
On submitting, the Agentless test package integration policy should be created with a new managed agent policy
Note: locally the agentless API won't work, comment out this line to test https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/services/agent_policy_create.ts#L178
Edit integration should be disabled
Delete integration action should be enabled, when clicking it, the agent policy should be deleted too, navigating back to the list of agent policies

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

obltmachine · 2024-07-31T09:54:31Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

juliaElastic · 2024-07-31T10:00:34Z

/ci

juliaElastic · 2024-07-31T10:16:28Z

/ci

juliaElastic · 2024-07-31T11:58:42Z

/ci

kpollich · 2024-07-31T12:52:24Z

@kilfoyle - Could you help with a quick check of the text here 🙏

...olicy/create_package_policy_page/single_page_layout/components/setup_technology_selector.tsx

elasticmachine · 2024-07-31T13:35:58Z

Pinging @elastic/fleet (Team:Fleet)

...et/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx

kilfoyle · 2024-07-31T13:38:22Z

This looks great! I added a couple of small suggestions for the UI text.

…policy/create_package_policy_page/single_page_layout/components/setup_technology_selector.tsx Co-authored-by: David Kilfoyle <[email protected]>

…policy/details_page/components/package_policies/package_policies_table.tsx Co-authored-by: David Kilfoyle <[email protected]>

juliaElastic · 2024-07-31T14:51:50Z

Tried to test in kibana pr deployment, but it seems the agentless url is not set there (tried to enable the feature flag, but still the agentless selector is not showing up).

kpollich · 2024-07-31T14:57:33Z

Tried to test in kibana pr deployment, but it seems the agentless url is not set there (tried to enable the feature flag, but still the agentless selector is not showing up).

Agentless is only supported in serverless deployments for now, so ESS deployments won't be able to set up agentless.

seanrathier · 2024-07-31T15:47:29Z

Looks good, I have a comment and a question.

I am glad you have not moved the CSP plugin's SetupTechnology selector because we still have some ongoing work with that and we may migrate that later.

I also have a PR to add the Beta badge and default the selected value of the SetupTechnology to Agent-based. Are you doing the same? I saw some similar code changes in the setup_technology hook and I thought you were but it was not in the requirements.

seanrathier · 2024-07-31T15:52:40Z

Tried to test in kibana pr deployment, but it seems the agentless url is not set there (tried to enable the feature flag, but still the agentless selector is not showing up).

@juliaElastic If you deploy this to one of our Cloud First test environments and you use your @elastic.co account you can bypass the allow-deny list and edit the configurations to enable agentless in ESS

juliaElastic · 2024-08-01T06:31:51Z

I also have ahttps://github.com//pull/189217 and default the selected value of the SetupTechnology to Agent-based. Are you doing the same? I saw some similar code changes in the setup_technology hook and I thought you were but it was not in the requirements.

Yes, made that changes, it's in the description. We can unify the selector component with the one in cspm plugin later.

Ensure that even if supports_agentless: true is set, the policy editor default to the current agent-based option and the toggle is set to agent-based

Ensure that the agentless option is clearly marked as beta, and display a beta banner in the policy editor form itself to reiterate this when agentless mode is enabled

criamico

LGTM, left just a small comment.

x-pack/plugins/fleet/public/components/package_policy_actions_menu.tsx

kibana-ci · 2024-08-02T12:45:02Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0ddfe9e

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	1208	1209	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.8MB	1.8MB	+3.3KB

History

💔 Build #225549 failed d5e37cd
💛 Build #225065 was flaky 864a245
💔 Build #225000 failed 0657ea7
💔 Build #224969 failed fce23ec

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

…on policy (#190391) ## Summary Related to #183863 Follow up from #189934 (comment) Since the edit integration was re-enabled for agentless integration policies, we have to make sure to hide the agent policy change option when editing an agentless policy. This pr addresses that. To verify: - add CSPM integration with agentless setup technology - edit the integration policy - verify that the agent policies can't be modified - upload another agentless package (instruction [here](#189612)) - add Agentless integration with setup technology agentless - edit the integration policly - verify that the agent policies can't be modified <img width="1526" alt="image" src="https://github.com/user-attachments/assets/557cc6d4-37e7-43f6-b52a-3d5f4c073e1c"> <img width="1524" alt="image" src="https://github.com/user-attachments/assets/e890efa8-4faf-4608-9228-32debadb895a"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Added back agent monitoring on agentless policies as requested. It was incorrectly removed in #189612

add setup technology selector to add integration page

1ec8781

juliaElastic added release_note:enhancement ci:cloud-deploy Create or update a Cloud deployment labels Jul 31, 2024

juliaElastic self-assigned this Jul 31, 2024

Merge branch 'main' into agentless-support

83334cb

added title to disabled integration policy link

fce23ec

fix i18n ids

0657ea7

juliaElastic marked this pull request as ready for review July 31, 2024 12:05

juliaElastic requested review from a team as code owners July 31, 2024 12:05

kilfoyle reviewed Jul 31, 2024

View reviewed changes

...olicy/create_package_policy_page/single_page_layout/components/setup_technology_selector.tsx Outdated Show resolved Hide resolved

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 31, 2024

kilfoyle reviewed Jul 31, 2024

View reviewed changes

...et/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx Outdated Show resolved Hide resolved

juliaElastic and others added 4 commits July 31, 2024 16:05

Update x-pack/plugins/fleet/public/applications/fleet/sections/agent_…

6ac27e6

…policy/create_package_policy_page/single_page_layout/components/setup_technology_selector.tsx Co-authored-by: David Kilfoyle <[email protected]>

Update x-pack/plugins/fleet/public/applications/fleet/sections/agent_…

e0eab06

…policy/details_page/components/package_policies/package_policies_table.tsx Co-authored-by: David Kilfoyle <[email protected]>

added tests

d638b03

fix test, rename tittles

864a245

juliaElastic removed the ci:cloud-deploy Create or update a Cloud deployment label Jul 31, 2024

juliaElastic requested a review from criamico August 2, 2024 08:51

criamico approved these changes Aug 2, 2024

View reviewed changes

x-pack/plugins/fleet/public/components/package_policy_actions_menu.tsx Outdated Show resolved Hide resolved

juliaElastic and others added 2 commits August 2, 2024 12:50

null check

d5e37cd

Merge branch 'main' into agentless-support

0ddfe9e

juliaElastic merged commit e67b460 into elastic:main Aug 2, 2024
25 checks passed

kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 2, 2024

This was referenced Aug 6, 2024

[Fleet] Unify SetupTechnologySelector in Fleet and CSPM #189950

Open

[Fleet] hide changing agent policies when editing agentless integration policy #190391

Merged

juliaElastic mentioned this pull request Aug 28, 2024

[Fleet] add back monitoring for agentless policies #191635

Merged

juliaElastic added a commit that referenced this pull request Aug 29, 2024

[Fleet] add back monitoring for agentless policies (#191635)

2678101

Added back agent monitoring on agentless policies as requested. It was incorrectly removed in #189612

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] add setup technology selector to add integration page #189612

[Fleet] add setup technology selector to add integration page #189612

juliaElastic commented Jul 31, 2024 •

edited

Loading

obltmachine commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

kpollich commented Jul 31, 2024

elasticmachine commented Jul 31, 2024

kilfoyle commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

kpollich commented Jul 31, 2024

seanrathier commented Jul 31, 2024 •

edited

Loading

seanrathier commented Jul 31, 2024

juliaElastic commented Aug 1, 2024 •

edited

Loading

criamico left a comment

kibana-ci commented Aug 2, 2024

[Fleet] add setup technology selector to add integration page #189612

[Fleet] add setup technology selector to add integration page #189612

Conversation

juliaElastic commented Jul 31, 2024 • edited Loading

Summary

Steps to verify locally (ESS):

Checklist

obltmachine commented Jul 31, 2024

🤖 GitHub comments

juliaElastic commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

kpollich commented Jul 31, 2024

elasticmachine commented Jul 31, 2024

kilfoyle commented Jul 31, 2024

juliaElastic commented Jul 31, 2024

kpollich commented Jul 31, 2024

seanrathier commented Jul 31, 2024 • edited Loading

seanrathier commented Jul 31, 2024

juliaElastic commented Aug 1, 2024 • edited Loading

criamico left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 2, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

History

juliaElastic commented Jul 31, 2024 •

edited

Loading

seanrathier commented Jul 31, 2024 •

edited

Loading

juliaElastic commented Aug 1, 2024 •

edited

Loading