Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Unify SetupTechnologySelector in Fleet and CSPM #189950

Open
juliaElastic opened this issue Aug 6, 2024 · 1 comment · May be fixed by #189952
Open

[Fleet] Unify SetupTechnologySelector in Fleet and CSPM #189950

juliaElastic opened this issue Aug 6, 2024 · 1 comment · May be fixed by #189952
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@juliaElastic
Copy link
Contributor

juliaElastic commented Aug 6, 2024

Follow up after #189612

SetupTechnologySelector is currently duplicated in fleet and cspm plugins: https://github.com/search?q=repo%3Aelastic%2Fkibana%20SetupTechnologySelector&type=code

It should be refactored so that only the Fleet version remains, and the create package policy page renders it when the package supports agentless, for the extension view as well:

Currently the CSPM package doesn't have the agentless flag set, so the selector wouldn't be visible if we were to unify it now.

There are also some differences currently:

  • the agentless selector is wrapped in an accordion in the cspm view
  • the agentless selector is visible in edit mode too in the cspm view
@juliaElastic juliaElastic added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic linked a pull request Aug 6, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants