Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14] [Obs AI Assistant] Make sure arguments have a default (#185691) #188655

Merged
merged 3 commits into from
Jul 23, 2024
Merged

[8.14] [Obs AI Assistant] Make sure arguments have a default (#185691) #188655

merged 3 commits into from
Jul 23, 2024
+7 −4

Conversation

dgieselaar
Copy link
Member

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

@dgieselaar
[Obs AI Assistant] Make sure arguments have a default (elastic#185691)
d63b236 
In elastic#184933, we removed the
parameters for the `context` function, however, OpenAI requires at least
an empty `arguments` object, so requests fail. This PR sets arguments to
an empty JSON object (`"{}"`) if `function_call.arguments` is empty.

(cherry picked from commit 8f3359c)
@dgieselaar dgieselaar enabled auto-merge (squash) July 18, 2024 13:49
@dgieselaar dgieselaar mentioned this pull request Jul 18, 2024
Merged
@botelastic botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label Jul 18, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / Alerting transform alert rule types transform_health rule runs correctly

Metrics [docs]

✅ unchanged

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 669df43 into elastic:8.14 Jul 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

Assignees
No one assigned
Labels
backport Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgieselaar @obltmachine @elasticmachine @kibana-ci @neptunian