[Obs AI Assistant] Make sure arguments have a default #185691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
sorenlouv
approved these changes
Jun 10, 2024
dgieselaar
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
HistoryTo update your PR or re-run it, just comment with: cc @dgieselaar |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 18, 2024
In elastic#184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty. (cherry picked from commit 8f3359c)
dgieselaar
added a commit
that referenced
this pull request
Jul 23, 2024
#188655) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Make sure arguments have a default (#185691)](#185691) <!--- Backport version: 7.3.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT {commits} BACKPORT--> Co-authored-by: Sandra G <[email protected]>
1 task
colleenmcginnis
added a commit
that referenced
this pull request
Jul 29, 2024
## Summary Fixes elastic/observability-docs#4090 Related to #185691 This PR adds a known issue to the 8.14.3 release docs related to function calling when using the Observability AI Assistant with the OpenAI connector. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 29, 2024
## Summary Fixes elastic/observability-docs#4090 Related to elastic#185691 This PR adds a known issue to the 8.14.3 release docs related to function calling when using the Observability AI Assistant with the OpenAI connector. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 5184260)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 29, 2024
## Summary Fixes elastic/observability-docs#4090 Related to elastic#185691 This PR adds a known issue to the 8.14.3 release docs related to function calling when using the Observability AI Assistant with the OpenAI connector. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 5184260)
kibanamachine
referenced
this pull request
Jul 29, 2024
) # Backport This will backport the following commits from `main` to `8.14`: - [[DOCS] Add known issue to 8.14.3 release notes (#189236)](#189236) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Colleen McGinnis","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-29T18:46:24Z","message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:prev-minor","v8.16.0","v8.14.3"],"title":"[DOCS] Add known issue to 8.14.3 release notes","number":189236,"url":"https://github.com/elastic/kibana/pull/189236","mergeCommit":{"message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189236","number":189236,"mergeCommit":{"message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},{"branch":"8.14","label":"v8.14.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Colleen McGinnis <[email protected]>
kibanamachine
referenced
this pull request
Jul 29, 2024
) # Backport This will backport the following commits from `main` to `8.15`: - [[DOCS] Add known issue to 8.14.3 release notes (#189236)](#189236) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Colleen McGinnis","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-29T18:46:24Z","message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:prev-minor","v8.16.0","v8.14.3"],"title":"[DOCS] Add known issue to 8.14.3 release notes","number":189236,"url":"https://github.com/elastic/kibana/pull/189236","mergeCommit":{"message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189236","number":189236,"mergeCommit":{"message":"[DOCS] Add known issue to 8.14.3 release notes (#189236)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a known issue to the 8.14.3 release docs related to\r\nfunction calling when using the Observability AI Assistant with the\r\nOpenAI connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},{"branch":"8.14","label":"v8.14.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #184933, we removed the parameters for the
contextfunction, however, OpenAI requires at least an emptyargumentsobject, so requests fail. This PR sets arguments to an empty JSON object ("{}") iffunction_call.argumentsis empty.