-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.14] [Entity Analytics] Flaky Cypress test fixes (#186081) #187472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Fix 1: Press refresh button after using date picker on dashboard Closes elastic#183662 Closes elastic#183635 Closes elastic#183982 We shouldnt have to do this, but there is some condition where clicking apply gets the UI in a stuck state and I cant figure it out. ### Fix 2: Use more specific selector for search bar on risk score preview page Closes elastic#184133 We were using a generic selector `[data-test-subj="unifiedQueryInput"] textarea` which was bringing back two elements sometimes (no idea why), I have given the box its own dedicated selector to hopefully prevent this from happening --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c34bb46)
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
cc @hop-dev |
@elasticmachine merge upstream |
machadoum
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
closes #187472
This will backport the following commits from
main
to8.14
:Questions ?
Please refer to the Backport tool documentation