Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/dashboards/entity_analytics/legacy_risk_score·cy·ts - Entity Analytics Dashboard legacy risk score With host risk data With alerts data filters the alerts count with time range filters the alerts count with time range #183662

Closed
kibanamachine opened this issue May 16, 2024 · 5 comments · Fixed by #186081
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Entity Analytics Security Entity Analytics Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented May 16, 2024

A test failed on a tracked branch

AssertionError: Timed out retrying after 150000ms: Expected to find element: `[data-test-subj="loading-spinner"]`, but never found it.
    at updateDashboardTimeRange (webpack:///./tasks/entity_analytics.ts:34:26)
    at Context.eval (webpack:///./e2e/entity_analytics/dashboards/entity_analytics/legacy_risk_score.cy.ts:197:37)

First failure: kibana-on-merge - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 16, 2024
@kibanamachine kibanamachine added the Team:Entity Analytics Security Entity Analytics Team label May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 16, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.14

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.14

@hop-dev hop-dev self-assigned this Jun 12, 2024
hop-dev added a commit that referenced this issue Jun 18, 2024
### Fix 1: Press refresh button after using date picker on dashboard

Closes #183662
Closes #183635
Closes #183982

We shouldnt have to do this, but there is some condition where clicking
apply gets the UI in a stuck state and I cant figure it out.

### Fix 2: Use more specific selector for search bar on risk score
preview page

Closes #184133

We were using a generic selector `[data-test-subj="unifiedQueryInput"]
textarea` which was bringing back two elements sometimes (no idea why),
I have given the box its own dedicated selector to hopefully prevent
this from happening

---------

Co-authored-by: Kibana Machine <[email protected]>
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 18, 2024
### Fix 1: Press refresh button after using date picker on dashboard

Closes elastic#183662
Closes elastic#183635
Closes elastic#183982

We shouldnt have to do this, but there is some condition where clicking
apply gets the UI in a stuck state and I cant figure it out.

### Fix 2: Use more specific selector for search bar on risk score
preview page

Closes elastic#184133

We were using a generic selector `[data-test-subj="unifiedQueryInput"]
textarea` which was bringing back two elements sometimes (no idea why),
I have given the box its own dedicated selector to hopefully prevent
this from happening

---------

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine reopened this Jun 28, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.14

@hop-dev hop-dev self-assigned this Jul 3, 2024
hop-dev added a commit to hop-dev/kibana that referenced this issue Jul 3, 2024
### Fix 1: Press refresh button after using date picker on dashboard

Closes elastic#183662
Closes elastic#183635
Closes elastic#183982

We shouldnt have to do this, but there is some condition where clicking
apply gets the UI in a stuck state and I cant figure it out.

### Fix 2: Use more specific selector for search bar on risk score
preview page

Closes elastic#184133

We were using a generic selector `[data-test-subj="unifiedQueryInput"]
textarea` which was bringing back two elements sometimes (no idea why),
I have given the box its own dedicated selector to hopefully prevent
this from happening

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit c34bb46)
@hop-dev
Copy link
Contributor

hop-dev commented Jul 3, 2024

Back-porting the fix to 8.14 #187472

hop-dev referenced this issue Jul 4, 2024
# Backport
closes #187472

This will backport the following commits from `main` to `8.14`:
- [[Entity Analytics] Flaky Cypress test fixes
(#186081)](#186081)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mark
Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-18T13:27:26Z","message":"[Entity
Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press
refresh button after using date picker on dashboard\r\n\r\nCloses
https://github.com/elastic/kibana/issues/183662\r\nCloses
https://github.com/elastic/kibana/issues/183635\r\nCloses
https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have
to do this, but there is some condition where clicking\r\napply gets the
UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more
specific selector for search bar on risk score\r\npreview
page\r\n\r\nCloses
https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a
generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea`
which was bringing back two elements sometimes (no idea why),\r\nI have
given the box its own dedicated selector to hopefully prevent\r\nthis
from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Entity
Analytics","v8.15.0"],"number":186081,"url":"https://github.com/elastic/kibana/pull/186081","mergeCommit":{"message":"[Entity
Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press
refresh button after using date picker on dashboard\r\n\r\nCloses
https://github.com/elastic/kibana/issues/183662\r\nCloses
https://github.com/elastic/kibana/issues/183635\r\nCloses
https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have
to do this, but there is some condition where clicking\r\napply gets the
UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more
specific selector for search bar on risk score\r\npreview
page\r\n\r\nCloses
https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a
generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea`
which was bringing back two elements sometimes (no idea why),\r\nI have
given the box its own dedicated selector to hopefully prevent\r\nthis
from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186081","number":186081,"mergeCommit":{"message":"[Entity
Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press
refresh button after using date picker on dashboard\r\n\r\nCloses
https://github.com/elastic/kibana/issues/183662\r\nCloses
https://github.com/elastic/kibana/issues/183635\r\nCloses
https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have
to do this, but there is some condition where clicking\r\napply gets the
UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more
specific selector for search bar on risk score\r\npreview
page\r\n\r\nCloses
https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a
generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea`
which was bringing back two elements sometimes (no idea why),\r\nI have
given the box its own dedicated selector to hopefully prevent\r\nthis
from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728"}}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <[email protected]>
@hop-dev hop-dev closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Entity Analytics Security Entity Analytics Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants