Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Hover actions for panels #182535

Merged
merged 133 commits into from
Oct 25, 2024

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented May 2, 2024

Summary

Closes #151233.
Closes #175451.
Closes #169677.
Closes #185893.

This updates the design for the actions menu for dashboard panels. With this new design, the most common actions are promoted and available as you hover over the panels.

Screenshot 2024-08-12 at 1 01 45 PM

The remaining actions are available in a context menu similar to the one that exists today but with better organized sections.

Jun-12-2024 16-33-23

Notable changes:

  • Switch from context menu in panel title bar to hover actions
  • Add groupings to actions for organized sections in actions menu
  • Turn off CSS transforms on react-grid-layout
  • Hide title bar in edit mode when panel title disabled unless badges or notifications are visible
  • Renamed PresentationPanelContextMenu -> PresentationPanelHoverActions
  • Promote Explore in Discover action for Lens panels
  • Show panel filter notification in view mode and edit mode
  • Use discoverApp icon for actions that redirect to Discover

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 changed the title [POC][Dashboard] Floating actions for panels [POC][Dashboard] Hover actions for panels May 3, 2024
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 93789ae to 7691975 Compare May 6, 2024 15:40
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch 3 times, most recently from c92d076 to 34add9d Compare May 24, 2024 20:00
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 29, 2024
@cqliu1 cqliu1 changed the title [POC][Dashboard] Hover actions for panels [Dashboard] Hover actions for panels May 31, 2024
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 4b90167 to 3d5defd Compare June 4, 2024 18:50
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from c1da327 to 6924815 Compare June 12, 2024 22:50
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch 2 times, most recently from cb77397 to 16ff27d Compare July 17, 2024 15:24
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from af90b9f to c28d3cc Compare July 24, 2024 17:19
@cqliu1
Copy link
Contributor Author

cqliu1 commented Jul 25, 2024

/ci

@cqliu1
Copy link
Contributor Author

cqliu1 commented Aug 3, 2024

/ci

@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 9d93ea8 to 1d78ce5 Compare August 3, 2024 03:18
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] Hover actions for panels
(#182535)](#182535)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T07:59:41Z","message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Feature:Embedding","Team:Presentation","loe:large","impact:medium","Feature:Drilldowns","v9.0.0","Project:Dashboard
Usability","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0"],"title":"[Dashboard]
Hover actions for
panels","number":182535,"url":"https://github.com/elastic/kibana/pull/182535","mergeCommit":{"message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182535","number":182535,"mergeCommit":{"message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <[email protected]>
@cqliu1 cqliu1 deleted the dashboard/floating-actions-for-panels branch October 25, 2024 17:00
nickpeihl added a commit to nickpeihl/kibana that referenced this pull request Oct 29, 2024
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Nov 12, 2024
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Nov 12, 2024
cqliu1 added a commit that referenced this pull request Nov 13, 2024
…clean up for hover actions (#198454)

## Summary

Closes #198370. 
Follow up to #182535.

This removes border style overrides from the apps that support
embeddables and cleans up outline styles for presentation panel
borders/hover actions. I removed all of the dashboard specific border
styles and made them more generic for any embeddable panel. Now, the
borders respect the `showBorder` prop on the embeddable input. However
even when `showBorder` is `false`, a border is shown on focus/hover to
align with the border styles of the hover actions.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2024
…clean up for hover actions (elastic#198454)

## Summary

Closes elastic#198370.
Follow up to elastic#182535.

This removes border style overrides from the apps that support
embeddables and cleans up outline styles for presentation panel
borders/hover actions. I removed all of the dashboard specific border
styles and made them more generic for any embeddable panel. Now, the
borders respect the `showBorder` prop on the embeddable input. However
even when `showBorder` is `false`, a border is shown on focus/hover to
align with the border styles of the hover actions.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9af4bb5)
kibanamachine added a commit that referenced this pull request Nov 13, 2024
…d CSS clean up for hover actions (#198454) (#200051)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard Usability] Remove borders from presentation panel and CSS
clean up for hover actions
(#198454)](#198454)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T16:46:30Z","message":"[Dashboard
Usability] Remove borders from presentation panel and CSS clean up for
hover actions (#198454)\n\n## Summary\r\n\r\nCloses
#198370. \r\nFollow up to
#182535.\r\n\r\nThis removes border style overrides from the apps that
support\r\nembeddables and cleans up outline styles for presentation
panel\r\nborders/hover actions. I removed all of the dashboard specific
border\r\nstyles and made them more generic for any embeddable panel.
Now, the\r\nborders respect the `showBorder` prop on the embeddable
input. However\r\neven when `showBorder` is `false`, a border is shown
on focus/hover to\r\nalign with the border styles of the hover
actions.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9af4bb5b7f70c9f281f728b24292e89171dcc846","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","release_note:fix","Team:Presentation","loe:medium","impact:high","v9.0.0","ci:project-deploy-observability","ci:project-deploy-security","Team:obs-ux-management","backport:version","v8.17.0"],"title":"[Dashboard
Usability] Remove borders from presentation panel and CSS clean up for
hover
actions","number":198454,"url":"https://github.com/elastic/kibana/pull/198454","mergeCommit":{"message":"[Dashboard
Usability] Remove borders from presentation panel and CSS clean up for
hover actions (#198454)\n\n## Summary\r\n\r\nCloses
#198370. \r\nFollow up to
#182535.\r\n\r\nThis removes border style overrides from the apps that
support\r\nembeddables and cleans up outline styles for presentation
panel\r\nborders/hover actions. I removed all of the dashboard specific
border\r\nstyles and made them more generic for any embeddable panel.
Now, the\r\nborders respect the `showBorder` prop on the embeddable
input. However\r\neven when `showBorder` is `false`, a border is shown
on focus/hover to\r\nalign with the border styles of the hover
actions.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9af4bb5b7f70c9f281f728b24292e89171dcc846"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198454","number":198454,"mergeCommit":{"message":"[Dashboard
Usability] Remove borders from presentation panel and CSS clean up for
hover actions (#198454)\n\n## Summary\r\n\r\nCloses
#198370. \r\nFollow up to
#182535.\r\n\r\nThis removes border style overrides from the apps that
support\r\nembeddables and cleans up outline styles for presentation
panel\r\nborders/hover actions. I removed all of the dashboard specific
border\r\nstyles and made them more generic for any embeddable panel.
Now, the\r\nborders respect the `showBorder` prop on the embeddable
input. However\r\neven when `showBorder` is `false`, a border is shown
on focus/hover to\r\nalign with the border styles of the hover
actions.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9af4bb5b7f70c9f281f728b24292e89171dcc846"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…clean up for hover actions (elastic#198454)

## Summary

Closes elastic#198370. 
Follow up to elastic#182535.

This removes border style overrides from the apps that support
embeddables and cleans up outline styles for presentation panel
borders/hover actions. I removed all of the dashboard specific border
styles and made them more generic for any embeddable panel. Now, the
borders respect the `showBorder` prop on the embeddable input. However
even when `showBorder` is `false`, a border is shown on focus/hover to
align with the border styles of the hover actions.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…clean up for hover actions (elastic#198454)

## Summary

Closes elastic#198370. 
Follow up to elastic#182535.

This removes border style overrides from the apps that support
embeddables and cleans up outline styles for presentation panel
borders/hover actions. I removed all of the dashboard specific border
styles and made them more generic for any embeddable panel. Now, the
borders respect the `showBorder` prop on the embeddable input. However
even when `showBorder` is `false`, a border is shown on focus/hover to
align with the border styles of the hover actions.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
@roshan-elastic
Copy link

Hey @teresaalvarezsoler and folks,

This stuff looks awesome! We're going to pick up the 'Explore in Discover' and drop it into our Lens visualisations in Hosts (and try and build it into other things we touch with Lens too).

A couple of bits of feedback:

1. We're re-adding our custom action to 'Open in Lens' to the ... drop-down which will open the lens visualisation

This is what we had before but we need to re-add it:

image

Question : For users, being able to open an embedded Lens visualisation as easily as the new hover 'edit' button would be awesome. Can you see this being an option in the future?

Note : We can't allow people to use the 'edit' fly-out functionality as we can't let users save the visualisation back to the current place (e.g. all the host views)

2. We'd like to add the ability for people to 'copy to dashboard'
We were considering doing this but we don't want to invest in the effort of adding this custom action and supporting it:

Question: Do you have any plans to make this a standard option in lens that we could add to our visualisations?

cc @crespocarlos

@teresaalvarezsoler
Copy link

Hey @roshan-elastic, we didn't have any plans for these features since we haven't had any requests from solutions until now :) Maybe @ghudgins can sync with you to understand requirements and discuss effort with the team to decide on priorization.

@roshan-elastic
Copy link

Sounds good @teresaalvarezsoler cc @ghudgins

We don't have a strong requirement for these yet so wouldn't want to ask you to prioritise them yet - just good to know your plans.

As we look to scale the usage of Lens across O11y, I think we can make a better case for these.

@cqliu1 cqliu1 restored the dashboard/floating-actions-for-panels branch December 4, 2024 17:09
wajihaparvez added a commit that referenced this pull request Dec 20, 2024
## Summary

Updated instructions and visuals for the new hover actions feature. 
Also came across a mention of the Replace panel action and removed it
([#178596](#178596)).

Rel: [#182535](#182535) and
[#596](elastic/platform-docs-team#596)
Closes: [#580](elastic/platform-docs-team#580)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 20, 2024
## Summary

Updated instructions and visuals for the new hover actions feature.
Also came across a mention of the Replace panel action and removed it
([elastic#178596](elastic#178596)).

Rel: [elastic#182535](elastic#182535) and
[elastic#596](elastic/platform-docs-team#596)
Closes: [elastic#580](elastic/platform-docs-team#580)

(cherry picked from commit 5b8ffd6)
kibanamachine added a commit that referenced this pull request Dec 20, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Docs] Update dashboard docs for hover actions
(#204844)](#204844)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"wajihaparvez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-20T00:50:43Z","message":"[Docs]
Update dashboard docs for hover actions (#204844)\n\n##
Summary\r\n\r\nUpdated instructions and visuals for the new hover
actions feature. \r\nAlso came across a mention of the Replace panel
action and removed
it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel:
[#182535](#182535)
and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses:
[#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[Docs]
Update dashboard docs for hover
actions","number":204844,"url":"https://github.com/elastic/kibana/pull/204844","mergeCommit":{"message":"[Docs]
Update dashboard docs for hover actions (#204844)\n\n##
Summary\r\n\r\nUpdated instructions and visuals for the new hover
actions feature. \r\nAlso came across a mention of the Replace panel
action and removed
it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel:
[#182535](#182535)
and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses:
[#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204844","number":204844,"mergeCommit":{"message":"[Docs]
Update dashboard docs for hover actions (#204844)\n\n##
Summary\r\n\r\nUpdated instructions and visuals for the new hover
actions feature. \r\nAlso came across a mention of the Replace panel
action and removed
it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel:
[#182535](#182535)
and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses:
[#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: wajihaparvez <[email protected]>
wajihaparvez added a commit to wajihaparvez/kibana that referenced this pull request Dec 23, 2024
[Docs] Update dashboard docs for hover actions (elastic#204844)

Updated instructions and visuals for the new hover actions feature.
Also came across a mention of the Replace panel action and removed it
([elastic#178596](elastic#178596)).

Rel: [elastic#182535](elastic#182535) and
[elastic#596](elastic/platform-docs-team#596)
Closes: [elastic#580](elastic/platform-docs-team#580)
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
## Summary

Updated instructions and visuals for the new hover actions feature. 
Also came across a mention of the Replace panel action and removed it
([elastic#178596](elastic#178596)).

Rel: [elastic#182535](elastic#182535) and
[elastic#596](elastic/platform-docs-team#596)
Closes: [elastic#580](elastic/platform-docs-team#580)
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
## Summary

Updated instructions and visuals for the new hover actions feature. 
Also came across a mention of the Replace panel action and removed it
([elastic#178596](elastic#178596)).

Rel: [elastic#182535](elastic#182535) and
[elastic#596](elastic/platform-docs-team#596)
Closes: [elastic#580](elastic/platform-docs-team#580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative release_note:enhancement Team:obs-ux-management Observability Management User Experience Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.17.0 v9.0.0
Projects
None yet