Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove PANEL_NOTIFICATION_TRIGGER #186200

Open
cqliu1 opened this issue Jun 13, 2024 · 1 comment
Open

[Dashboard] Remove PANEL_NOTIFICATION_TRIGGER #186200

cqliu1 opened this issue Jun 13, 2024 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Jun 13, 2024

Currently notifications can be registered to appear on relevant panels in the title bar.

As part of #182535, both the libary notification and drilldowns notifications will be removed. The panel filters notification will be the only action left using the PANEL_NOTIFICATION_TRIGGER, so we should do some clean up and remove the notification trigger entirely in favor of CONTEXT_MENU_TRIGGER for the panel filters notification.

Moving forward with our new designs for handling panel actions, it is likely if we need to register any type of notification in the future, we won't want it to appear in the panel title bar, and it should be added to either hover actions or the context menu.

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative labels Jun 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 changed the title [Dashboard] Remove PANEL_NOTICATION_TRIGGER [Dashboard] Remove PANEL_NOTIFICATION_TRIGGER Jun 13, 2024
@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants