Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.13] [ES|QL] case only requires two parameters (#179011) #179165

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[8.13] [ES|QL] case only requires two parameters (#179011) #179165

merged 1 commit into from
Mar 21, 2024

Conversation

drewdaemon
Copy link
Contributor

Backport

This will backport the following commits from main to 8.13:

Questions ?

Please refer to the Backport tool documentation

@drewdaemon
[ES|QL] case only requires two parameters (elastic#179011)
4a05a70 
## Summary

Part of elastic#177699

We had `case` marked as if it required three parameters when in reality
it only requires two.

<img width="600" alt="Screenshot 2024-03-19 at 4 23 29 PM"
src="https://github.com/elastic/kibana/assets/315764/45f7578a-e6ad-4ba9-b71a-05bb1978a384">

Note: we could consider testing these n-1 cases to prevent this kind of
bug in the future.

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
(cherry picked from commit 28277c2)

# Conflicts:
#	packages/kbn-monaco/src/esql/lib/ast/validation/esql_validation_meta_tests.json
@drewdaemon drewdaemon enabled auto-merge (squash) March 21, 2024 15:58
@drewdaemon drewdaemon mentioned this pull request Mar 21, 2024
Merged
@drewdaemon drewdaemon requested a review from dej611 March 21, 2024 15:58
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 2549f8d into elastic:8.13 Mar 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewdaemon @kibana-ci @mbondyra