[ES|QL] case only requires two parameters #179011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
5 tasks
drewdaemon
added
backport:prev-minor
|
@elasticmachine merge upstream |
|
/ci |
stratoula
approved these changes
Mar 21, 2024
dej611
approved these changes
Mar 21, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Mar 21, 2024
## Summary Part of elastic#177699 We had `case` marked as if it required three parameters when in reality it only requires two. <img width="600" alt="Screenshot 2024-03-19 at 4 23 29 PM" src="https://github.com/elastic/kibana/assets/315764/45f7578a-e6ad-4ba9-b71a-05bb1978a384"> Note: we could consider testing these n-1 cases to prevent this kind of bug in the future. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]> (cherry picked from commit 28277c2) # Conflicts: # packages/kbn-monaco/src/esql/lib/ast/validation/esql_validation_meta_tests.json
drewdaemon
added a commit
that referenced
this pull request
Mar 21, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[ES|QL] case only requires two parameters (#179011)](#179011) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-21T14:34:38Z","message":"[ES|QL] case only requires two parameters (#179011)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/177699\r\n\r\nWe had `case` marked as if it required three parameters when in reality\r\nit only requires two.\r\n\r\n<img width=\"600\" alt=\"Screenshot 2024-03-19 at 4 23 29 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/315764/45f7578a-e6ad-4ba9-b71a-05bb1978a384\">\r\n\r\nNote: we could consider testing these n-1 cases to prevent this kind of\r\nbug in the future.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"28277c25df26796a8aa51cb4b8e82b0483c9cf83","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","v8.14.0"],"number":179011,"url":"https://github.com/elastic/kibana/pull/179011","mergeCommit":{"message":"[ES|QL] case only requires two parameters (#179011)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/177699\r\n\r\nWe had `case` marked as if it required three parameters when in reality\r\nit only requires two.\r\n\r\n<img width=\"600\" alt=\"Screenshot 2024-03-19 at 4 23 29 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/315764/45f7578a-e6ad-4ba9-b71a-05bb1978a384\">\r\n\r\nNote: we could consider testing these n-1 cases to prevent this kind of\r\nbug in the future.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"28277c25df26796a8aa51cb4b8e82b0483c9cf83"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179011","number":179011,"mergeCommit":{"message":"[ES|QL] case only requires two parameters (#179011)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/177699\r\n\r\nWe had `case` marked as if it required three parameters when in reality\r\nit only requires two.\r\n\r\n<img width=\"600\" alt=\"Screenshot 2024-03-19 at 4 23 29 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/315764/45f7578a-e6ad-4ba9-b71a-05bb1978a384\">\r\n\r\nNote: we could consider testing these n-1 cases to prevent this kind of\r\nbug in the future.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"28277c25df26796a8aa51cb4b8e82b0483c9cf83"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #177699
We had
casemarked as if it required three parameters when in reality it only requires two.Note: we could consider testing these n-1 cases to prevent this kind of bug in the future.