Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v64 (main) #176872

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 13, 2024

Mend Renovate

fixes #176417

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 63.1.0 -> 64.0.0 age adoption passing confidence

Release Notes

elastic/elastic-charts (@​elastic/charts)

v64.0.0

Compare Source

Bug Fixes
chore
BREAKING CHANGES
  • metric: Moves MetricSpec.body to MetricDatum.body/MetricBase.body
  • bullet: Rename BulletGraph to Bullet and ColorBandSimpleConfig.classes to steps

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 13, 2024
@nickofthyme nickofthyme marked this pull request as ready for review February 13, 2024 22:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme enabled auto-merge (squash) February 13, 2024 22:43
@renovate renovate bot requested review from a team as code owners February 14, 2024 17:16
@renovate renovate bot requested a review from a team as a code owner February 15, 2024 22:46
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Feb 15, 2024
@elastic elastic deleted a comment from renovate bot Feb 15, 2024
@nickofthyme nickofthyme requested a review from markov00 February 15, 2024 22:54
@markov00
Copy link
Member

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

/ci

@nickofthyme
Copy link
Contributor

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionGauge 91 89 -2
expressionHeatmap 159 157 -2
expressionLegacyMetricVis 36 34 -2
expressionMetricVis 100 98 -2
expressionPartitionVis 174 172 -2
expressionTagcloud 148 146 -2
expressionXY 234 232 -2
lens 1344 1343 -1
visualizations 405 403 -2
total -17

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/chart-expressions-common 22 19 -3
expressions 1762 1757 -5
total -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1015.3KB 1015.3KB -35.0B
expressionGauge 19.0KB 19.0KB -55.0B
expressionHeatmap 26.5KB 26.5KB +1.0B
expressionLegacyMetricVis 11.9KB 11.9KB +1.0B
expressionPartitionVis 36.4KB 36.4KB -28.0B
expressionTagcloud 18.8KB 18.8KB -1.0B
expressionXY 128.5KB 128.4KB -42.0B
lens 1.4MB 1.4MB -58.0B
visualizations 274.9KB 274.1KB -750.0B
total -967.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 16.5KB 14.7KB -1.8KB
expressionHeatmap 15.7KB 14.9KB -754.0B
expressionLegacyMetricVis 11.0KB 10.3KB -744.0B
expressionMetricVis 14.5KB 13.7KB -754.0B
expressionPartitionVis 27.4KB 26.7KB -753.0B
expressions 99.0KB 98.7KB -273.0B
expressionTagcloud 11.5KB 10.8KB -753.0B
expressionXY 40.5KB 38.8KB -1.7KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -6.6KB
visualizations 57.6KB 57.6KB -54.0B
total -14.0KB
Unknown metric groups

API count

id before after diff
@kbn/chart-expressions-common 27 23 -4
expressions 2224 2216 -8
total -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme
Copy link
Contributor

Ping @elastic/kibana-presentation, @elastic/kibana-data-discovery, @elastic/obs-ux-infra_services-team for codeowner review.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.13.0 v8.14.0 and removed backport:skip This commit does not require backporting labels Feb 21, 2024
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. Glad that we got so fast that we don't need the veil anymore 👏

@@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.waitUntilSearchingHasFinished();
// this is the number of renderings of the histogram needed when new data is fetched
let renderingCountInc = 1;
let renderingCountInc = 3; // Multiple renders caused by https://github.com/elastic/kibana/issues/177055
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be 1 if we increase the window size for these tests?

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Data Discovery changes 👍
Hopefully, the rerenderings issues are not noticeable and can be resolved.

@nickofthyme nickofthyme merged commit 8773be3 into main Feb 21, 2024
41 checks passed
@nickofthyme nickofthyme deleted the renovate/main-@elasticcharts branch February 21, 2024 16:49
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.13 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 176872

Questions ?

Please refer to the Backport tool documentation

@nickofthyme
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nickofthyme pushed a commit to nickofthyme/kibana that referenced this pull request Feb 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
[`63.1.0` ->
`64.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/63.1.0/64.0.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v64.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6400-2024-02-13)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v63.1.0...v64.0.0)

##### Bug Fixes

- **deps:** update dependency
[@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^93.1.0
([#&elastic#8203;2332](https://togithub.com/elastic/elastic-charts/issues/2332))
([855e357](https://togithub.com/elastic/elastic-charts/commit/855e357ab4433c7fc5a0e7e2c2398150ff686e41))
- **deps:** update dependency
[@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v93
([#&elastic#8203;2324](https://togithub.com/elastic/elastic-charts/issues/2324))
([ce19379](https://togithub.com/elastic/elastic-charts/commit/ce1937910211f812b7a4eed371337e6498b1e6b3))
- **deps:** update dependency
[@&elastic#8203;playwright/test](https://togithub.com/playwright/test) to
^1.41.2
([#&elastic#8203;2330](https://togithub.com/elastic/elastic-charts/issues/2330))
([1f8c638](https://togithub.com/elastic/elastic-charts/commit/1f8c638356edebab8fc14d9ebdcaceec3e10812e))
- **metric:** move `MetricSpec.body` to `MetricBase`
([#&elastic#8203;2336](https://togithub.com/elastic/elastic-charts/issues/2336))
([3390e25](https://togithub.com/elastic/elastic-charts/commit/3390e251d3edc37ca68e13ff3acd8843b3b5a6ba))
- use passed size in pixel without waiting for resizeObserver
([#&elastic#8203;2270](https://togithub.com/elastic/elastic-charts/issues/2270))
([f9c11fc](https://togithub.com/elastic/elastic-charts/commit/f9c11fca2a284e4ca3744a02dc743d09b78f64b8))

##### chore

- **bullet:** bullet improvements, bug fixes and renaming
([#&elastic#8203;2319](https://togithub.com/elastic/elastic-charts/issues/2319))
([34fd38b](https://togithub.com/elastic/elastic-charts/commit/34fd38b77cdd060057a38e25c6197de6807839d2))

##### BREAKING CHANGES

- **metric:** Moves `MetricSpec.body` to
`MetricDatum.body`/`MetricBase.body`
- **bullet:** Rename `BulletGraph` to `Bullet` and
`ColorBandSimpleConfig.classes` to `steps`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/elastic/kibana).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
(cherry picked from commit 8773be3)

# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
nickofthyme added a commit that referenced this pull request Feb 22, 2024
…7526)

# Backport

This will backport the following commits from `main` to `8.13`:
- [Update dependency @elastic/charts to v64 (main)
(#176872)](#176872)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
[`63.1.0` ->
`64.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/63.1.0/64.0.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v64.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6400-2024-02-13)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v63.1.0...v64.0.0)

##### Bug Fixes

- **deps:** update dependency
[@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^93.1.0
([#&elastic#8203;2332](https://togithub.com/elastic/elastic-charts/issues/2332))
([855e357](https://togithub.com/elastic/elastic-charts/commit/855e357ab4433c7fc5a0e7e2c2398150ff686e41))
- **deps:** update dependency
[@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v93
([#&elastic#8203;2324](https://togithub.com/elastic/elastic-charts/issues/2324))
([ce19379](https://togithub.com/elastic/elastic-charts/commit/ce1937910211f812b7a4eed371337e6498b1e6b3))
- **deps:** update dependency
[@&elastic#8203;playwright/test](https://togithub.com/playwright/test) to
^1.41.2
([#&elastic#8203;2330](https://togithub.com/elastic/elastic-charts/issues/2330))
([1f8c638](https://togithub.com/elastic/elastic-charts/commit/1f8c638356edebab8fc14d9ebdcaceec3e10812e))
- **metric:** move `MetricSpec.body` to `MetricBase`
([#&elastic#8203;2336](https://togithub.com/elastic/elastic-charts/issues/2336))
([3390e25](https://togithub.com/elastic/elastic-charts/commit/3390e251d3edc37ca68e13ff3acd8843b3b5a6ba))
- use passed size in pixel without waiting for resizeObserver
([#&elastic#8203;2270](https://togithub.com/elastic/elastic-charts/issues/2270))
([f9c11fc](https://togithub.com/elastic/elastic-charts/commit/f9c11fca2a284e4ca3744a02dc743d09b78f64b8))

##### chore

- **bullet:** bullet improvements, bug fixes and renaming
([#&elastic#8203;2319](https://togithub.com/elastic/elastic-charts/issues/2319))
([34fd38b](https://togithub.com/elastic/elastic-charts/commit/34fd38b77cdd060057a38e25c6197de6807839d2))

##### BREAKING CHANGES

- **metric:** Moves `MetricSpec.body` to
`MetricDatum.body`/`MetricBase.body`
- **bullet:** Rename `BulletGraph` to `Bullet` and
`ColorBandSimpleConfig.classes` to `steps`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/elastic/kibana).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Chart become blank after removing a breakdown field that returned no-data.
10 participants