-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @elastic/charts to v64 (main) #176872
Conversation
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
/ci |
x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
Outdated
Show resolved
Hide resolved
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Ping @elastic/kibana-presentation, @elastic/kibana-data-discovery, @elastic/obs-ux-infra_services-team for codeowner review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-presentation changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great. Glad that we got so fast that we don't need the veil anymore 👏
@@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
await PageObjects.common.navigateToApp('discover'); | |||
await PageObjects.discover.waitUntilSearchingHasFinished(); | |||
// this is the number of renderings of the histogram needed when new data is fetched | |||
let renderingCountInc = 1; | |||
let renderingCountInc = 3; // Multiple renders caused by https://github.com/elastic/kibana/issues/177055 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be 1
if we increase the window size for these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving Data Discovery changes 👍
Hopefully, the rerenderings issues are not noticeable and can be resolved.
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@elastic/charts](https://togithub.com/elastic/elastic-charts) | [`63.1.0` -> `64.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/63.1.0/64.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary> ### [`v64.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6400-2024-02-13) [Compare Source](https://togithub.com/elastic/elastic-charts/compare/v63.1.0...v64.0.0) ##### Bug Fixes - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^93.1.0 ([#&elastic#8203;2332](https://togithub.com/elastic/elastic-charts/issues/2332)) ([855e357](https://togithub.com/elastic/elastic-charts/commit/855e357ab4433c7fc5a0e7e2c2398150ff686e41)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v93 ([#&elastic#8203;2324](https://togithub.com/elastic/elastic-charts/issues/2324)) ([ce19379](https://togithub.com/elastic/elastic-charts/commit/ce1937910211f812b7a4eed371337e6498b1e6b3)) - **deps:** update dependency [@&elastic#8203;playwright/test](https://togithub.com/playwright/test) to ^1.41.2 ([#&elastic#8203;2330](https://togithub.com/elastic/elastic-charts/issues/2330)) ([1f8c638](https://togithub.com/elastic/elastic-charts/commit/1f8c638356edebab8fc14d9ebdcaceec3e10812e)) - **metric:** move `MetricSpec.body` to `MetricBase` ([#&elastic#8203;2336](https://togithub.com/elastic/elastic-charts/issues/2336)) ([3390e25](https://togithub.com/elastic/elastic-charts/commit/3390e251d3edc37ca68e13ff3acd8843b3b5a6ba)) - use passed size in pixel without waiting for resizeObserver ([#&elastic#8203;2270](https://togithub.com/elastic/elastic-charts/issues/2270)) ([f9c11fc](https://togithub.com/elastic/elastic-charts/commit/f9c11fca2a284e4ca3744a02dc743d09b78f64b8)) ##### chore - **bullet:** bullet improvements, bug fixes and renaming ([#&elastic#8203;2319](https://togithub.com/elastic/elastic-charts/issues/2319)) ([34fd38b](https://togithub.com/elastic/elastic-charts/commit/34fd38b77cdd060057a38e25c6197de6807839d2)) ##### BREAKING CHANGES - **metric:** Moves `MetricSpec.body` to `MetricDatum.body`/`MetricBase.body` - **bullet:** Rename `BulletGraph` to `Bullet` and `ColorBandSimpleConfig.classes` to `steps` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 8773be3) # Conflicts: # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@elastic/charts](https://togithub.com/elastic/elastic-charts) | [`63.1.0` -> `64.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/63.1.0/64.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/63.1.0/64.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary> ### [`v64.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6400-2024-02-13) [Compare Source](https://togithub.com/elastic/elastic-charts/compare/v63.1.0...v64.0.0) ##### Bug Fixes - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^93.1.0 ([#&elastic#8203;2332](https://togithub.com/elastic/elastic-charts/issues/2332)) ([855e357](https://togithub.com/elastic/elastic-charts/commit/855e357ab4433c7fc5a0e7e2c2398150ff686e41)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v93 ([#&elastic#8203;2324](https://togithub.com/elastic/elastic-charts/issues/2324)) ([ce19379](https://togithub.com/elastic/elastic-charts/commit/ce1937910211f812b7a4eed371337e6498b1e6b3)) - **deps:** update dependency [@&elastic#8203;playwright/test](https://togithub.com/playwright/test) to ^1.41.2 ([#&elastic#8203;2330](https://togithub.com/elastic/elastic-charts/issues/2330)) ([1f8c638](https://togithub.com/elastic/elastic-charts/commit/1f8c638356edebab8fc14d9ebdcaceec3e10812e)) - **metric:** move `MetricSpec.body` to `MetricBase` ([#&elastic#8203;2336](https://togithub.com/elastic/elastic-charts/issues/2336)) ([3390e25](https://togithub.com/elastic/elastic-charts/commit/3390e251d3edc37ca68e13ff3acd8843b3b5a6ba)) - use passed size in pixel without waiting for resizeObserver ([#&elastic#8203;2270](https://togithub.com/elastic/elastic-charts/issues/2270)) ([f9c11fc](https://togithub.com/elastic/elastic-charts/commit/f9c11fca2a284e4ca3744a02dc743d09b78f64b8)) ##### chore - **bullet:** bullet improvements, bug fixes and renaming ([#&elastic#8203;2319](https://togithub.com/elastic/elastic-charts/issues/2319)) ([34fd38b](https://togithub.com/elastic/elastic-charts/commit/34fd38b77cdd060057a38e25c6197de6807839d2)) ##### BREAKING CHANGES - **metric:** Moves `MetricSpec.body` to `MetricDatum.body`/`MetricBase.body` - **bullet:** Rename `BulletGraph` to `Bullet` and `ColorBandSimpleConfig.classes` to `steps` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fixes #176417
This PR contains the following updates:
63.1.0
->64.0.0
Release Notes
elastic/elastic-charts (@elastic/charts)
v64.0.0
Compare Source
Bug Fixes
MetricSpec.body
toMetricBase
(#2336) (3390e25)chore
BREAKING CHANGES
MetricSpec.body
toMetricDatum.body
/MetricBase.body
BulletGraph
toBullet
andColorBandSimpleConfig.classes
tosteps
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.