Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Search bad intractability on narrow screen #177055

Open
nickofthyme opened this issue Feb 15, 2024 · 7 comments
Open

Unified Search bad intractability on narrow screen #177055

nickofthyme opened this issue Feb 15, 2024 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nickofthyme
Copy link
Contributor

Kibana version:

8.13, latest

Describe the bug:

When using an app such as discover with unified search, when the query bar width is overly confided such that the time picker is pushed to a new row the UI unnecessarily jumps around a lot. Main contributing factors of this are...

  • Narrow browser window, especially in serverless with the side nav open.
  • A wide time picker display (i.e. both start and end are absolute times)

The problem is that in this state where the time picker is pushed to a second row, as soon as the user clicks the query bar, the timepicker width is collapsed causing the time picker to move back to the first row and jumps all the content up with it to remove the now empty row. Then blurring the query bar does the reverse and jumps the content down.

Expected behavior:

Ideally we prevent any collapsing of the time picker once it's pushed to the second row, as there's no longer a need to make more room for the query bar in this state, in fact doing so currently actually reduces the query bar width.

Screenshots (if relevant):

Screen.Recording.2024-02-15.at.10.37.40.AM.mp4

Notice when focusing and blurring the query bar how the entire page contents jump up and down.

@nickofthyme nickofthyme added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:Unified search Unified search related tasks labels Feb 15, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 15, 2024
@nickofthyme nickofthyme added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 15, 2024
@nickofthyme nickofthyme changed the title Unified search bad intractability on narrow screen Unified Search bad intractability on narrow screen Feb 15, 2024
@stratoula stratoula added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Feb 18, 2024
@stratoula
Copy link
Contributor

I am changing this to enhancement because:

  • it is something we know and we had agreed to keep it like that
  • responsiveness is not great in kibana in general
  • there are some conversations about redesign so I think it will be good to deal with responsiveness after the redesign

@nickofthyme
Copy link
Contributor Author

I agree, this just caused a failure in the functional tests with the shift causing unnecessary chart rerenders. Just wanted to make note of this for future enhancement.

@stratoula
Copy link
Contributor

stratoula commented Feb 20, 2024

How this causes rerenders to the FT? Are we resizing or something? 🤔

@nickofthyme
Copy link
Contributor Author

How this causes rerenders to the FT? Are we resizing or something? 🤔

In the serverless environment with the side nav open making discover narrower, you have the TimePicker pushed to the bottom. In one functional test, the test focuses the query bar then blurs it for some assertion. This blurring of the query bar causes the collapse of the time picker and the chart container fills the space momentarily and causes the chart to render 3 additional times. To be clear this is not perceptible but the tests are asserting render count, which caused the error, see #176872 (comment).

@stratoula
Copy link
Contributor

Yes thanx Nick, it is clear now :)

@jb1b84 jb1b84 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks labels Jan 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jb1b84 jb1b84 removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 21, 2025
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 21, 2025
@jb1b84 jb1b84 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Unified search Unified search related tasks labels Jan 21, 2025
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants