Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Fix vagrant unzip #175754

Merged
merged 3 commits into from
Jan 27, 2024
Merged

[EDR Workflows] Fix vagrant unzip #175754

merged 3 commits into from
Jan 27, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Jan 27, 2024

Not sure what happened but vagrant up started to fail due to finding unzip package issue.

Zrzut ekranu 2024-01-27 o 16 37 46

This PR fixes this.

However after the upgrade - unzip package seems to be returning different output.
Zrzut ekranu 2024-01-27 o 16 54 00

That's why I adjusted the test from equal to contain.

This is a quick fix done on Saturday (I am off on Monday), so if someone has some time during the working hours and feels that this could be fixed in a better way, please feel free to do so :)

Thank you!

@tomsonpl tomsonpl self-assigned this Jan 27, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.1 v8.13.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 27, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl marked this pull request as ready for review January 27, 2024 17:04
@tomsonpl tomsonpl requested a review from a team as a code owner January 27, 2024 17:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl tomsonpl enabled auto-merge (squash) January 27, 2024 17:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl merged commit f4b0bd7 into elastic:main Jan 27, 2024
35 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 29, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [[EDR Workflows] Fix vagrant unzip
(#175754)](#175754)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-27T17:07:55Z","message":"[EDR
Workflows] Fix vagrant unzip
(#175754)","sha":"f4b0bd7d7b5f0fece2b61b7b5af077b20067e562","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.12.1","v8.13.0"],"title":"[EDR Workflows] Fix vagrant
unzip","number":175754,"url":"https://github.com/elastic/kibana/pull/175754","mergeCommit":{"message":"[EDR
Workflows] Fix vagrant unzip
(#175754)","sha":"f4b0bd7d7b5f0fece2b61b7b5af077b20067e562"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175754","number":175754,"mergeCommit":{"message":"[EDR
Workflows] Fix vagrant unzip
(#175754)","sha":"f4b0bd7d7b5f0fece2b61b7b5af077b20067e562"}}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
dasansol92 added a commit that referenced this pull request Feb 2, 2024
## Summary
Re-enable skipped e2e tests due vagrant up error. This pr depends on
this change: #175755
Originally merged at main here:
#175754

fixes: #170811
fixes: #170674
fixes: #169343
fixes: #170601
fixes: #173464
fixes: #170667
fixes: #170812
fixes: #170604
fixes: #170373
fixes: #169958
fixes: #170814
fixes: #170424
fixes: #170706
fixes: #170563
fixes: #169689
fixes: #170817
fixes: #169821
fixes: #170816
fixes: #170794

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants