[EDR Workflows] Unskip e2e tests due vagrant up error #175780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
release_note:skip
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
dasansol92
requested review from
a team,
ashokaditya and
paul-tavares
and removed request for
a team
ashokaditya
approved these changes
Jan 30, 2024
| @@ -21,8 +21,7 @@ import { enableAllPolicyProtections } from '../../../tasks/endpoint_policy'; | |||
| import { createEndpointHost } from '../../../tasks/create_endpoint_host'; | |||
| import { deleteAllLoadedEndpointData } from '../../../tasks/delete_all_endpoint_data'; | |||
|
|
|||
| // Failing: See https://github.com/elastic/kibana/issues/170424 | |||
| describe.skip('Response console', { tags: ['@ess', '@serverless'] }, () => { | |||
| describe('Response console', { tags: ['@ess', '@serverless'] }, () => { | |||
There was a problem hiding this comment.
You can also undo the change on line 115 on this file. Since Kibana v18.2 is on node 18.18.2, the assumption that the package unzip causes issues on the test is not relevant on this branch. So it should be back to expect(unzippedFileContent).to.equal(fileContent);
ashokaditya
approved these changes
Jan 31, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Feb 2, 2024
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable skipped e2e tests due vagrant up error. This pr depends on this change: #175755
Originally merged at main here: #175754
closes: #170811
closes: #170674
closes: #169343
closes: #170601
closes: #173464
closes: #170667
closes: #170812
closes: #170604
closes: #170373
closes: #169958
closes: #170814
closes: #170424
closes: #170706
closes: #170563
closes: #169689
closes: #170817
closes: #169821
closes: #170816
closes: #170794
For maintainers