Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] Remove Gainsight from cloud plugin (#172318) #174886

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

bollinic
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

- Remove gainsight plugin from cloud plugin
- add config deprecation in fullstory

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit de961a5)
@bollinic bollinic enabled auto-merge (squash) January 16, 2024 10:15
Copy link
Contributor

Documentation preview:

@bollinic bollinic disabled auto-merge January 16, 2024 10:16
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #14 / Response console From Cases should open responder should open responder

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudGainsight 7 - -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/analytics-shippers-gainsight 2 - -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudGainsight 2.1KB - -2.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudGainsight 3.5KB - -3.5KB
Unknown metric groups

API count

id before after diff
@kbn/analytics-shippers-gainsight 18 - -18

async chunk count

id before after diff
cloudGainsight 1 - -1

ESLint disabled in files

id before after diff
@kbn/analytics-shippers-gainsight 1 - -1
cloudGainsight 2 - -2
total -3

ESLint disabled line counts

id before after diff
cloudGainsight 1 - -1

Total ESLint disabled count

id before after diff
@kbn/analytics-shippers-gainsight 1 - -1
cloudGainsight 3 - -3
total -4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bollinic bollinic enabled auto-merge (squash) January 16, 2024 14:07
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM. I noticed the CODEOWNERS file was left out of the changeset, but IIRC that only exists main

@bollinic bollinic merged commit 16c90ef into elastic:8.12 Jan 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants