-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gainsight from cloud plugin #172318
Conversation
Documentation preview: |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in core_plugins/rendering.ts
LGTM, thanks!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@shahinakmal I am missing your review please |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
## Summary - Remove gainsight plugin from cloud plugin - add config deprecation in fullstory Co-authored-by: kibanamachine <[email protected]>
## Summary - Remove gainsight plugin from cloud plugin - add config deprecation in fullstory Co-authored-by: kibanamachine <[email protected]>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
- Remove gainsight plugin from cloud plugin - add config deprecation in fullstory Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit de961a5)
# Backport This will backport the following commits from `main` to `8.12`: - [Remove Gainsight from cloud plugin (#172318)](#172318) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cecilia Bollini","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-09T10:21:56Z","message":"Remove Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove gainsight plugin from cloud plugin\r\n- add config deprecation in fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","auto-backport","backport:prev-minor","v8.12.0","v8.13.0"],"number":172318,"url":"https://github.com/elastic/kibana/pull/172318","mergeCommit":{"message":"Remove Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove gainsight plugin from cloud plugin\r\n- add config deprecation in fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172318","number":172318,"mergeCommit":{"message":"Remove Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove gainsight plugin from cloud plugin\r\n- add config deprecation in fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c"}}]}] BACKPORT-->
This PR didn't make it into the latest BC for 8.12.0. Updating the labels. |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.