Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gainsight from cloud plugin #172318

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

bollinic
Copy link
Contributor

@bollinic bollinic commented Nov 30, 2023

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

Copy link
Contributor

Documentation preview:

@bollinic bollinic changed the title [DRAFT] Remove Gainsight Remove Gainsight from cloud plugin Jan 3, 2024
@bollinic bollinic marked this pull request as ready for review January 3, 2024 07:36
@bollinic bollinic requested review from a team and shahinakmal as code owners January 3, 2024 07:36
@bollinic bollinic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 3, 2024
@bollinic
Copy link
Contributor Author

bollinic commented Jan 3, 2024

@elasticmachine merge upstream

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in core_plugins/rendering.ts LGTM, thanks!

@bollinic
Copy link
Contributor Author

bollinic commented Jan 3, 2024

@elasticmachine merge upstream

@bollinic
Copy link
Contributor Author

bollinic commented Jan 8, 2024

@elasticmachine merge upstream

@bollinic
Copy link
Contributor Author

bollinic commented Jan 8, 2024

@shahinakmal I am missing your review please

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudGainsight 7 - -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/analytics-shippers-gainsight 2 - -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudGainsight 2.1KB - -2.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudGainsight 3.5KB - -3.5KB
Unknown metric groups

API count

id before after diff
@kbn/analytics-shippers-gainsight 18 - -18

async chunk count

id before after diff
cloudGainsight 1 - -1

ESLint disabled in files

id before after diff
@kbn/analytics-shippers-gainsight 1 - -1
cloudGainsight 2 - -2
total -3

ESLint disabled line counts

id before after diff
cloudGainsight 1 - -1

Total ESLint disabled count

id before after diff
@kbn/analytics-shippers-gainsight 1 - -1
cloudGainsight 3 - -3
total -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bollinic bollinic merged commit de961a5 into elastic:main Jan 9, 2024
37 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 9, 2024
@bollinic bollinic removed the backport:skip This commit does not require backporting label Jan 10, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2024
@bollinic bollinic added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jan 10, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 10, 2024
## Summary
- Remove gainsight plugin from cloud plugin
- add config deprecation in fullstory



Co-authored-by: kibanamachine <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
## Summary
- Remove gainsight plugin from cloud plugin
- add config deprecation in fullstory



Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 12, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172318 locally

@bollinic bollinic added auto-backport Deprecated - use backport:version if exact versions are needed v8.12.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 15, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.12 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 172318

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@bollinic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

bollinic added a commit to bollinic/kibana that referenced this pull request Jan 16, 2024
- Remove gainsight plugin from cloud plugin
- add config deprecation in fullstory

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit de961a5)
bollinic added a commit that referenced this pull request Jan 16, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [Remove Gainsight from cloud plugin
(#172318)](#172318)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cecilia
Bollini","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-09T10:21:56Z","message":"Remove
Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove
gainsight plugin from cloud plugin\r\n- add config deprecation in
fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","auto-backport","backport:prev-minor","v8.12.0","v8.13.0"],"number":172318,"url":"https://github.com/elastic/kibana/pull/172318","mergeCommit":{"message":"Remove
Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove
gainsight plugin from cloud plugin\r\n- add config deprecation in
fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172318","number":172318,"mergeCommit":{"message":"Remove
Gainsight from cloud plugin (#172318)\n\n## Summary\r\n- Remove
gainsight plugin from cloud plugin\r\n- add config deprecation in
fullstory\r\n\r\n\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de961a54a7cdcd19636f2dab07f3882e3d61bc8c"}}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 16, 2024
@mistic mistic added v8.12.1 and removed v8.12.0 labels Jan 17, 2024
@mistic
Copy link
Member

mistic commented Jan 17, 2024

This PR didn't make it into the latest BC for 8.12.0. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants