[Fleet] Fix asset creation during custom integration installation

[weltenwort]

📝 Summary

This fixes the way the asset paths are extracted since #173965. Since the assetMap is a Map, the keys can be retrieved via assetMap.keys().

• closes Observability Logs Onboarding breaks installed Integrations page #174803

[elasticmachine]

Pinging @elastic/fleet (Feature:EPM)

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[weltenwort]

Sorry about the wrong committer e-mail 🙈 I'll force-push a fixed commit.

[nchaulet]

Thanks for fixing this, we should probably have some tests that cover that path too do you mind creating a follow up issue for that?

[mgiota]

@weltenwort I verify that your fix works well, so I am closing my draft PR.

[mgiota]

LGTM!

[mgiota]

@weltenwort I did a bit more testing and as you can see when I uninstall my custom integration and reinstall it again it fails.

Screen.Recording.2024-01-15.at.22.35.49.mov

Also the Overview page of the custom integration is empty.

This PR is approved, since it fixes the described issue. Above comments can be fixed in follow up issues. Not sure though if the uninstall/re-install issue is related only to the custom integration installation or if it is a general fleet issue. @nchaulet could weigh in here.

[nchaulet]

Not sure though if the uninstall/re-install issue is related only to the custom integration installation or if it is a general fleet issue. @nchaulet could weigh in here.

The issue seems to be only related to the custom integration as when it's uninstalled we do not have the assets anymore (that make it impossible for us to reinstall it)

I am wondering if we should just remove that install button for custom integration, or redirect somewhere else than that details page

[mgiota]

I am wondering if we should just remove that install button for custom integration, or redirect somewhere else than that details page

Yep removing that install button sounds like a good idea to me.

[mgiota]

@weltenwort I am reopening my PR, since your PR fixes newly created custom integrations. If the custom integration is in a broken state already, users will continue to get this error Cannot read properties of undefined (reading 'split').

After me clicking on this reinstall button, I somehow ended up in a broken state and the Installed Integrations page was empty. After me applying the initial fix, the custom integration would not appear in the Installed Integrations page, but at least I could see my rest installed Integrations and following warning on the server [WARN ][plugins.fleet] Installed package my_custom_integration 1.0.0 is not a valid package anymore. So I guess your PR didn't mean to replace my PR, just complement it and fix the root of the problem.

[weltenwort]

@nchaulet thanks for the review. We actually have a test that caught this, but it was circumvented in #174734 instead of fixing the problem. We're discussing steps to make sure the test always runs on the PRs that are most likely to break this functionality.

@mgiota thanks for checking. I'll investigate and possibly create a follow-up issue to disable the install button.

[yngrdyn]

@weltenwort we can bring back the test to the previous form, I just saw the PR as a patch because it was blocking something important behind. wdyt?

[weltenwort]

@yngrdyn ok, I'll try to restore it and enable it for fleet-related changes in one go

[weltenwort]

@mgiota @nchaulet I created a follow-up issue to remove the "(re)install" buttons/sections: #174930

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 970fa20

Metrics [docs]

✅ unchanged

History

• 💚 Build #187559 succeeded 7ebfe01

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

[Ikuni17]

OPs changes lgtm

[mgiota]

@weltenwort Cool! How about the empty Overview page of the Custom Integration?

Update: I created this follow up issue. If needed, feel free to update.

[weltenwort]

@mgiota good point, thanks for creating the issue. We should definitely generate a readme too 👍

[yngrdyn]

LGTM

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.12	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 174869

Questions ?

Please refer to the Backport tool documentation

[weltenwort]

I don't think backports are necessary, because the change that broke this wasn't backported either.