-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Share getStartedPage between ESS and serverless #174867
Conversation
buildkite test this |
buildkite test this |
buildkite test this |
buildkite test this |
buildkite test this |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
x-pack/plugins/security_solution/public/common/components/landing_page/onboarding/configs.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/app/components/onboarding/onboarding_page_service.ts
Outdated
Show resolved
Hide resolved
I desk-tested the PR and I've noticed a problem in the ESS environment. The side navigation is not showing on the onboarding page: This is caused by the absolute positioning of the main onboarding component, these are styles are only work for serverless. Probably this component should not be absolute, also, we are nesting a second |
The 2nd KibanaPageTemplate in the Onboarding component is now removed: ESS: Screen.Recording.2024-01-24.at.21.04.46.movServerless: Screen.Recording.2024-01-24.at.20.56.50.mov |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @angorayc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for doing this. great work!
Linking a follow-up task to make the onboarding page component agnostic, and move the specific serverless/ess code to their appropriate plugins: #174766 |
I've also put all the follow up tasks in this issue: #174742 |
…lastic#174867) ## Summary elastic#174742 This PR move the get_started component from `security_solution_serverless` plugin to `security_solution` plugin, so we can share the same UI between ESS and serverless. Parameters are set via `x-pack/plugins/security_solution/public/contract_get_started_page.ts` 1. productTypes - set by serverless only 2. projectsUrl - set by serverless only (when running serverless locally, this value is empty) 3. projectFeaturesUrl - set by serverless only (when running serverless locally, this value is empty) 4. availableSteps - set by both serverless and ESS (ESS doesn't contain `create your first project` step) Known issue: elastic#175296 --- #### Serverless: 6 steps in total + the first step is finished by default ![serverless](https://github.com/elastic/kibana/assets/6295984/8bbf6557-8c8e-42c6-843b-fc24ac1dd178) #### ESS: 5 steps in total ![Screenshot 2024-01-24 at 20 04 19](https://github.com/elastic/kibana/assets/6295984/6486916a-9976-4fb5-bf07-721ba4d411aa) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
Summary
#174742
This PR move the get_started component from
security_solution_serverless
plugin tosecurity_solution
plugin, so we can share the same UI between ESS and serverless.Parameters are set via
x-pack/plugins/security_solution/public/contract_get_started_page.ts
create your first project
step)Known issue: #175296
Serverless: 6 steps in total + the first step is finished by default
ESS: 5 steps in total
Checklist